feat: NTRN-332. Add tokenfactory module #131

albertandrejev · 2023-01-24T10:19:22Z

Osmosis has the token factory module that allows anyone to create new native tokens. We want to have it in Neutron, so we need to see if it’s possible to easily include it to our codebase: osmosis/x/tokenfactory at main · osmosis-labs/osmosis

Main reason why we decided to copypaste code because we also want to integrate ibc hooks module as well and wanted to have everything under our control.

Dependent:
neutron-org/neutron-integration-tests#75
neutron-org/neutron-docs#52

Depends on:
neutron-org/neutron-dev-contracts#8

Task: NTRN-332
Test run

pr0n00gler · 2023-01-25T08:46:54Z

go.mod

@@ -137,5 +135,6 @@ replace (
 	github.com/cosmos/admin-module => github.com/Ethernal-Tech/admin-module v0.0.0-20221102105340-e693f4d379c3
 	github.com/cosmos/ibc-go/v3 => github.com/informalsystems/ibc-go/v3 v3.0.0-beta1.0.20220816140824-aba9c2f2b943
 	github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1
+	github.com/osmosis-labs/osmosis/v10 v10.2.0 => github.com/neutron-org/osmosis/v10 v10.2.0-native-sdk-4


I think we need a separate branch in our osmosis fork (like we did with wasmd fork) where we will push necessary changes for us.
Also it's easier to see the diff

pr0n00gler

We should leave an info that this module is a copy paste from Osmosis.
And maybe some License file

larry0x · 2023-03-08T14:31:36Z

ICYMI, there is a maintained standalone repo for token-factory, so you can perhaps avoid copy-pasting the entire module codebase into this repo: https://github.com/CosmWasm/token-factory

larry0x · 2023-03-08T14:35:22Z

Also, I don't see wasm bindings for token-factory. The bindings are needed for contracts to actually use the module. See Osmosis' bindings here: https://github.com/osmosis-labs/osmosis/blob/main/wasmbinding/bindings/msg.go#L6-L17

albertandrejev · 2023-03-08T18:47:25Z

ICYMI, there is a maintained standalone repo for token-factory, so you can perhaps avoid copy-pasting the entire module codebase into this repo: https://github.com/CosmWasm/token-factory

Yes we saw it but thank you anyway. We decided to copypaste code because we also want to integrate ibc hooks module as well and wanted to have everything under our control.

albertandrejev · 2023-03-08T18:52:36Z

Also, I don't see wasm bindings for token-factory. The bindings are needed for contracts to actually use the module. See Osmosis' bindings here: https://github.com/osmosis-labs/osmosis/blob/main/wasmbinding/bindings/msg.go#L6-L17

Thanks for pointing this out. I will implement it as well!

pacmanifold · 2023-03-16T17:07:19Z

@albertandrejev there has been some recent development on the token factory in the osmosis repo to introduce side effects.

osmosis-labs/osmosis#4382
osmosis-labs/osmosis#4417
osmosis-labs/osmosis#4590

Any chance these features could be included in the integration of token factory into neutron. It would be extremely useful 🙏

albertandrejev · 2023-03-16T17:44:24Z

@albertandrejev there has been some recent development on the token factory in the osmosis repo to introduce side effects.

osmosis-labs/osmosis#4382 osmosis-labs/osmosis#4417 osmosis-labs/osmosis#4590

Any chance these features could be included in the integration of token factory into neutron. It would be extremely useful pray

Thank you for your message but there is difficulties to implement some of these features:

Tokenfactory: Add Before send hooks osmosis-labs/osmosis#4382 requires modified version of Cosmos SDK (Hooks support for the Bank module)
[TokenFactory] Add ForceTranfer, BurnFrom and MintTo osmosis-labs/osmosis#4417 we need to discuss it
[TokenFactory] Bank Hooks Integration osmosis-labs/osmosis#4590 same issue with modified version of Cosmos SDK

testutil/test_helpers.go

wasmbinding/bindings/query.go

wasmbinding/custom_querier.go

wasmbinding/message_plugin.go

wasmbinding/queries.go

x/tokenfactory/README.md

x/tokenfactory/client/cli/query.go

x/tokenfactory/client/cli/tx.go

x/tokenfactory/keeper/admins_test.go

x/tokenfactory/keeper/keeper.go

x/tokenfactory/keeper/keeper_test.go

x/tokenfactory/types/msgs.go

The base branch was changed.

pr0n00gler · 2023-03-31T09:52:30Z

wasmbinding/bindings/msg.go

+	CreateDenom *CreateDenom `json:"create_denom,omitempty"`
+	/// Contracts can change the admin of a denom that they are the admin of.
+	ChangeAdmin *ChangeAdmin `json:"change_admin,omitempty"`
+	/// Contracts can mint native tokens for an existing factory denom
+	/// that they are the admin of.
+	MintTokens *MintTokens `json:"mint_tokens,omitempty"`
+	/// Contracts can burn native tokens for an existing factory denom
+	/// that they are the admin of.
+	/// Currently, the burn from address must be the admin contract.
+	BurnTokens *BurnTokens `json:"burn_tokens,omitempty"`


There are bindings on Neutron side but I don't necessary changes in our cosmwasm neurton-sdk. Am I wrong?

missed this point, thanks!

pr0n00gler · 2023-03-31T09:53:57Z

wasmbinding/custom_querier.go

+
+			bz, err := json.Marshal(res)
+			if err != nil {
+				return nil, fmt.Errorf("failed to JSON marshal DenomAdminResponse response: %w", err)


You use sdkerrors.Wrap everywhere above, but here you use fmt.Errorf. Why?

It was copypasted from https://github.com/osmosis-labs/osmosis/blob/dcc5b61fcbf5e3715c01da9268e82b1791e82257/wasmbinding/query_plugin.go#L84

pr0n00gler · 2023-03-31T09:54:45Z

wasmbinding/custom_querier.go

+		case contractQuery.DenomAdmin != nil:
+			res, err := qp.GetDenomAdmin(ctx, contractQuery.DenomAdmin.Subdenom)
+			if err != nil {
+				return nil, err


Please wrap an error with some meaningful description

pr0n00gler · 2023-03-31T09:56:47Z

wasmbinding/message_plugin.go

+	_, err = msgServer.Mint(sdk.WrapSDKContext(ctx), sdkMsg)
+	if err != nil {
+		return sdkerrors.Wrap(err, "minting coins from message")
+	}


Not critical, but we usually leave \n after error handling

albertandrejev changed the base branch from main to neutron_audit_informal_17_01_2023_fixes January 24, 2023 10:19

albertandrejev changed the base branch from neutron_audit_informal_17_01_2023_fixes to neutron_audit_informal_17_01_2023 January 24, 2023 10:20

albertandrejev changed the title ~~feat: NTRN-332. Add treasury module~~ feat: NTRN-332. Add tokenfactory module Jan 24, 2023

albertandrejev requested review from foxpy, pr0n00gler and dusan-maksimovic January 24, 2023 14:59

pr0n00gler reviewed Jan 25, 2023

View reviewed changes

albertandrejev mentioned this pull request Jan 31, 2023

feat: NTRN-332. Test token factory neutron-org/neutron-integration-tests#75

Merged

albertandrejev force-pushed the feat/NTRN-332-add-token-factory branch from 02b1904 to 2de813c Compare January 31, 2023 10:36

zavgorodnii previously approved these changes Feb 1, 2023

View reviewed changes

foxpy approved these changes Feb 7, 2023

View reviewed changes

albertandrejev marked this pull request as draft February 7, 2023 09:09

albertandrejev force-pushed the feat/NTRN-332-add-token-factory branch from 9494728 to 4c674b1 Compare March 2, 2023 13:27

zavgorodnii marked this pull request as ready for review March 7, 2023 13:18

foxpy requested review from foxpy and zavgorodnii March 7, 2023 13:19

pr0n00gler reviewed Mar 8, 2023

View reviewed changes

albertandrejev mentioned this pull request Mar 13, 2023

feat: NTRN-332. Reflect token factory queries neutron-org/neutron-dev-contracts#8

Merged

albertandrejev requested a review from pr0n00gler March 13, 2023 08:18

albertandrejev mentioned this pull request Mar 13, 2023

feat: NTRN-332. Add Osmosis Tokenfactory docs neutron-org/neutron-docs#52

Merged

albertandrejev force-pushed the feat/NTRN-332-add-token-factory branch from 6703089 to 5ea153d Compare March 20, 2023 19:24

foxpy requested changes Mar 21, 2023

View reviewed changes

albertandrejev requested a review from foxpy March 21, 2023 14:17

foxpy requested changes Mar 21, 2023

View reviewed changes

foxpy self-requested a review March 22, 2023 13:53

albertandrejev changed the base branch from neutron_audit_informal_17_01_2023 to main March 22, 2023 14:00

foxpy previously approved these changes Mar 23, 2023

View reviewed changes

albertandrejev dismissed foxpy’s stale review via c797f61 March 27, 2023 20:03

albertandrejev force-pushed the feat/NTRN-332-add-token-factory branch from 07c6cae to c797f61 Compare March 27, 2023 20:03

albertandrejev added 2 commits March 27, 2023 23:20

Add treasury module

75f13b3

Update reflect contract

d73669a

albertandrejev force-pushed the feat/NTRN-332-add-token-factory branch from c797f61 to d73669a Compare March 27, 2023 20:39

Fix lint errors

db3ccc4

albertandrejev requested a review from foxpy March 28, 2023 09:06

albertandrejev added 4 commits March 29, 2023 23:22

Update proto and generated files

1d57007

remove not used cretion fee params

1480078

Fix tests

fad646c

Change authority_metadata REST params

247141c

pr0n00gler requested changes Mar 31, 2023

View reviewed changes

fix review remarks

27dcb08

pr0n00gler previously approved these changes Mar 31, 2023

View reviewed changes

foxpy previously approved these changes Apr 3, 2023

View reviewed changes

Merge branch 'main' into feat/NTRN-332-add-token-factory

54cde79

pr0n00gler dismissed stale reviews from foxpy and themself via 54cde79 April 3, 2023 14:21

foxpy approved these changes Apr 3, 2023

View reviewed changes

pr0n00gler approved these changes Apr 3, 2023

View reviewed changes

pr0n00gler merged commit b112fe5 into main Apr 3, 2023

pr0n00gler deleted the feat/NTRN-332-add-token-factory branch January 11, 2024 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: NTRN-332. Add tokenfactory module #131

feat: NTRN-332. Add tokenfactory module #131

albertandrejev commented Jan 24, 2023 •

edited by pr0n00gler

Loading

pr0n00gler Jan 25, 2023

albertandrejev Jan 25, 2023

pr0n00gler left a comment

larry0x commented Mar 8, 2023

larry0x commented Mar 8, 2023

albertandrejev commented Mar 8, 2023

albertandrejev commented Mar 8, 2023

pacmanifold commented Mar 16, 2023

albertandrejev commented Mar 16, 2023

pr0n00gler Mar 31, 2023

albertandrejev Mar 31, 2023

pr0n00gler Mar 31, 2023

albertandrejev Mar 31, 2023

pr0n00gler Mar 31, 2023

pr0n00gler Mar 31, 2023

feat: NTRN-332. Add tokenfactory module #131

feat: NTRN-332. Add tokenfactory module #131

Conversation

albertandrejev commented Jan 24, 2023 • edited by pr0n00gler Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pr0n00gler left a comment

Choose a reason for hiding this comment

larry0x commented Mar 8, 2023

larry0x commented Mar 8, 2023

albertandrejev commented Mar 8, 2023

albertandrejev commented Mar 8, 2023

pacmanifold commented Mar 16, 2023

albertandrejev commented Mar 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

albertandrejev commented Jan 24, 2023 •

edited by pr0n00gler

Loading