Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TokenFactory] Bank Hooks Integration #4590

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Conversation

mattverse
Copy link
Member

What is the purpose of the change

In osmosis-labs/cosmos-sdk#421, bank hooks has been separated out into two hooks.

  1. TrackBeforeSend
  2. BlockBeforeSend

This PR adopts the concept introduced in osmosis-labs/cosmos-sdk#421, integrating the hooks with the token factory module.

The cosmos-sdk dependency has been changed due to the reasons mentioned above, for now created v16.x branch from the latest v15.x branch, cherry picked the commit from the PR mentioned above.

Brief Changelog

  • Add Token Factory Bank Hooks Integration

Testing and Verifying

Existing tests have been modified and new tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@mattverse mattverse requested a review from nicolaslara March 13, 2023 09:20
@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:x/tokenfactory labels Mar 13, 2023
@mattverse mattverse added the V:state/breaking State machine breaking PR label Mar 13, 2023
Copy link
Contributor

@nicolaslara nicolaslara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. C:x/tokenfactory V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants