-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] detrend R-R intervals #711
Conversation
also added some comments
since intervals are meant to be more general (can be breath-to-breath)
Preprocessed intervals, in milliseconds. | ||
intervals_time : array | ||
Preprocessed timestamps corresponding to intervals, in seconds. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some examples here?
Awesome, last two little things; should we rename Also, we can add th new exported function to the documentation |
Codecov ReportBase: 52.65% // Head: 52.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #711 +/- ##
==========================================
+ Coverage 52.65% 52.74% +0.09%
==========================================
Files 277 279 +2
Lines 12588 12624 +36
==========================================
+ Hits 6628 6659 +31
- Misses 5960 5965 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
All good for me, feel free to merge! |
Awesome, is it fine for me to merge #710 first? Since this is based off of that one |
Yup! |
Description
This PR aims to add the ability to detrend R-R intervals as a preprocessing step. See also #671 (comment)
Proposed Changes
I changed the
intervals_preprocess()
function so that it optionally callssignal_detrend()
by passingdetrend_method
.Checklist