[DOC] Update constraints and example for NB_NODES variable value
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssadai
changed the title
NB_NODES variable valueNB_NODES variable value
surchs
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
nice find @alyssadai. Could you also make an issue to check for this "" thing separately, and also on the node-API repo? We probably want to confirm this problem and then have a check and a test for the check so it doesn't come back
This was referenced Nov 15, 2023
|
Relevant issues have been opened, and this behaviour has also been documented in our internal wiki. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/and add if missing #21Quotations
""around the value of a variable in.envseem to be passed directly to the Docker container, which causes problems when the node URLs are parsed.See also docker/compose#8388
Checklist
[ENH],[FIX],[REF],[TST],[CI],[MNT],[INF],[MODEL],[DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXXFor new features:
For bug fixes: