Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that value of NB_NODES is not in quotations #23

Closed
2 tasks
alyssadai opened this issue Nov 15, 2023 · 1 comment
Closed
2 tasks

Check that value of NB_NODES is not in quotations #23

alyssadai opened this issue Nov 15, 2023 · 1 comment
Labels
flag:schedule Flag issue that should go on the roadmap or backlog. maint:usability General improvements to product usability that are unrelated to feature prioritization.

Comments

@alyssadai
Copy link
Contributor

See our internal wiki https://github.com/neurobagel/documentation/wiki/Docker#docker-cli-docker-run for why the quotes are a problem

  • emit warning if quotes are found (since they will be interpreted literally by the container) and strip them inside the code
  • add a test for the new check

Originally posted by @surchs in #22 (review)
@alyssadai alyssadai added maint:usability General improvements to product usability that are unrelated to feature prioritization. type:maintenance flag:schedule Flag issue that should go on the roadmap or backlog. labels Nov 15, 2023
@alyssadai
Copy link
Contributor Author

alyssadai commented Dec 5, 2023 •
edited
Loading

No longer planned as the configuration of local nodes is now handled by a .json file that's mounted into the container.

@alyssadai alyssadai closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag:schedule Flag issue that should go on the roadmap or backlog. maint:usability General improvements to product usability that are unrelated to feature prioritization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alyssadai