Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config route conditional #657

Merged
merged 5 commits into from
May 10, 2019
Merged

Config route conditional #657

merged 5 commits into from
May 10, 2019

Conversation

dalazx
Copy link
Collaborator

@dalazx dalazx commented May 8, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #657 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   93.75%   93.81%   +0.06%     
==========================================
  Files          30       30              
  Lines        3809     3832      +23     
  Branches      411      411              
==========================================
+ Hits         3571     3595      +24     
- Misses        175      176       +1     
+ Partials       63       61       -2
Impacted Files Coverage Δ
platform_api/kube_cluster.py 100% <100%> (ø) ⬆️
platform_api/handlers/models_handler.py 98.46% <100%> (ø) ⬆️
platform_api/api.py 89.31% <100%> (+1.27%) ⬆️
platform_api/handlers/jobs_handler.py 97.45% <100%> (+0.36%) ⬆️
platform_api/orchestrator/job.py 98.85% <100%> (ø) ⬆️
platform_api/orchestrator/jobs_service.py 96.31% <100%> (-1.19%) ⬇️
platform_api/cluster.py 100% <100%> (ø) ⬆️
platform_api/orchestrator/jobs_telemetry.py 100% <0%> (+13.33%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented May 9, 2019 •
edited
Loading

Codecov Report

Merging #657 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   93.75%   93.81%   +0.06%     
==========================================
  Files          30       30              
  Lines        3809     3832      +23     
  Branches      411      411              
==========================================
+ Hits         3571     3595      +24     
- Misses        175      176       +1     
+ Partials       63       61       -2
Impacted Files Coverage Δ
platform_api/kube_cluster.py 100% <100%> (ø) ⬆️
platform_api/handlers/models_handler.py 98.46% <100%> (ø) ⬆️
platform_api/api.py 89.31% <100%> (+1.27%) ⬆️
platform_api/handlers/jobs_handler.py 97.45% <100%> (+0.36%) ⬆️
platform_api/orchestrator/job.py 98.85% <100%> (ø) ⬆️
platform_api/orchestrator/jobs_service.py 96.31% <100%> (-1.19%) ⬇️
platform_api/cluster.py 100% <100%> (ø) ⬆️
platform_api/orchestrator/jobs_telemetry.py 100% <0%> (+13.33%) ⬆️

This was referenced May 9, 2019
Closed
Merged
@dalazx
Copy link
Collaborator Author

dalazx commented May 9, 2019

blocked by the client PRs.

@dalazx dalazx merged commit 359dc05 into master May 10, 2019
@dalazx dalazx deleted the config_route_conditional branch May 10, 2019 14:38
@atemate atemate mentioned this pull request May 29, 2019
Closed
@atemate atemate mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atemate atemate atemate approved these changes

Assignees
No one assigned
Labels
compute platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalazx @atemate @astaff