Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the config once logged in #766

Merged
merged 2 commits into from
May 10, 2019
Merged

Refresh the config once logged in #766

merged 2 commits into from
May 10, 2019

Conversation

atemate
Copy link
Contributor

@atemate atemate commented May 9, 2019

Closes #760.

NOTE: this PR will fix client after this feature is supported server-side (see PR neuro-inc/platform-api#657)

@atemate atemate requested review from asvetlov, dalazx and shagren May 9, 2019 17:08
@astaff astaff added the platform label May 9, 2019
@atemate atemate force-pushed the ay/config-refresh-logged branch from af660ea to f4d706e Compare May 9, 2019 20:02
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #766 into master will decrease coverage by 1.61%.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #766      +/-   ##
========================================
- Coverage   90.62%    89%   -1.62%     
========================================
  Files          38     38              
  Lines        3231   3256      +25     
  Branches      456    460       +4     
========================================
- Hits         2928   2898      -30     
- Misses        222    266      +44     
- Partials       81     92      +11
Impacted Files Coverage Δ
neuromation/api/images.py 84.54% <0%> (-7.98%) ⬇️
neuromation/api/jobs.py 91.4% <100%> (-0.35%) ⬇️
neuromation/api/storage.py 97.76% <100%> (-2.24%) ⬇️
neuromation/api/registry.py 100% <100%> (ø) ⬆️
neuromation/api/users.py 83.92% <100%> (ø) ⬆️
neuromation/cli/utils.py 93.18% <100%> (-1.82%) ⬇️
neuromation/api/config_factory.py 95.79% <100%> (-1.43%) ⬇️
neuromation/api/config.py 76.92% <100%> (ø) ⬆️
neuromation/api/login.py 97.97% <100%> (+0.47%) ⬆️
neuromation/api/core.py 98.33% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eef209...f4d706e. Read the comment docs.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #766 into master will increase coverage by 1.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
+ Coverage   89.27%   90.83%   +1.56%     
==========================================
  Files          38       38              
  Lines        3255     3253       -2     
  Branches      460      460              
==========================================
+ Hits         2906     2955      +49     
+ Misses        258      219      -39     
+ Partials       91       79      -12
Impacted Files Coverage Δ
neuromation/api/config_factory.py 97.47% <100%> (+1.71%) ⬆️
neuromation/api/login.py 97.97% <100%> (+0.37%) ⬆️
neuromation/api/jobs.py 91.75% <0%> (+0.34%) ⬆️
neuromation/cli/formatters/jobs.py 94.32% <0%> (+0.87%) ⬆️
neuromation/cli/main.py 61.25% <0%> (+1.57%) ⬆️
neuromation/cli/utils.py 95% <0%> (+1.81%) ⬆️
neuromation/api/storage.py 100% <0%> (+2.23%) ⬆️
neuromation/api/images.py 92.52% <0%> (+5.6%) ⬆️
neuromation/api/url_utils.py 100% <0%> (+8.82%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9d748...aaf2c7a. Read the comment docs.

@atemate atemate force-pushed the ay/config-refresh-logged branch 2 times, most recently from ab2b13b to 4322474 Compare May 9, 2019 21:58
Copy link
Contributor

@shagren shagren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There missed changelog file. I think it is required because after this update user will need to logout/login. This information must be in changelog.

neuromation/api/config_factory.py Outdated Show resolved Hide resolved
neuromation/api/login.py Outdated Show resolved Hide resolved
@atemate atemate force-pushed the ay/config-refresh-logged branch from 4322474 to d9a08ea Compare May 10, 2019 13:28
@atemate
Copy link
Contributor Author

atemate commented May 10, 2019

Thank you @shagren ! changelog note added!

@atemate atemate merged commit 020a5d7 into master May 10, 2019
@atemate atemate deleted the ay/config-refresh-logged branch May 10, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh the config once logged in
4 participants