add special domain keys to data

[mazabou]

the Data object is defined by a domain which is an interval object. but more generally we would want to associate different domains with this object. In particular there are two types:

1. split domains: this would be the train_domain, test_domain etc... which help define the domains from which to sample for a given split
2. epoch domains: in certain experiments, we will have different "epochs" where a task is performed, this can be defined as a domain as well. so we will have drifting_gratings_domain, natural_movies_domain etc...

These domains are "higher order entities" and are exempt from splitting, so we skip them.

---

In current code, trials is not checked for data leakage. instead of removing this, currently it is simply deprecated

[vinamarora8]

Shouldn't we remove this whole logic? I believe "trials" is not a general concept, and so we shouldn't have an if-else for it in temporaldata

[vinamarora8]

I tagged likes 2902-2914 here. GH only shows a few for some reason

[mazabou]

This was old code that I wanted to deprecate so that I don't break too many things for people (or at least provide a clear error so they know what to fix), but I am down to also completely remove it.

[vinamarora8]

I get why this is needed, and I don't mind current implementations. Though I have a reservation about using object names to decide what logic will be executed on them. It's an opinion, but I don't think it's clean. Another way, which I right now think avoids this is - create a new class Domain that is a subclass of Interval, and then condition on the object being a Domain or not.

[mazabou]

I am open to that. The only drawback is that people will not think that domains are also intervals, or that they can do & and | between domains and intervals. also how do we resolve Domain & Interval, will the output be a Domain or an Interval?

[vinamarora8]

I don't see that as a problem. Equivalently, people wouldn't know if they name something "_domain", then it behaves differently. One has to read the docs to understand what's going on in either case.
Re. Domain & Interval, I would say make the output an interval. And we can have something like a classmethod to promote Interval objects to Domain objects.