Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified arista_eos_show_vlan to list Ports issue #908 #909

Closed
wants to merge 675 commits into from
Closed

Modified arista_eos_show_vlan to list Ports issue #908 #909

wants to merge 675 commits into from

Conversation

bharath-ravindranath
Copy link

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

arista_eos_show_vlan.textfsm, arista_eos, show vlan

SUMMARY

The change mostly copied from cisco_ios_show_valn.textfsm template. The output format is very similar on Arista EOS. This Fixes #908

Before:

[{'name': 'default', 'status': 'active', 'vlan_id': '1'},
 {'name': 'Test1', 'status': 'active', 'vlan_id': '10'},
 {'name': 'Test2', 'status': 'suspended', 'vlan_id': '20'},
 {'name': 'VLAN0030', 'status': 'suspended', 'vlan_id': '30'}]

With Fix:

[{'interfaces': ['Et1'], 'name': 'default', 'status': 'active', 'vlan_id': '1'},
 {'interfaces': ['Et1', 'Et2'], 'name': 'Test1', 'status': 'active', 'vlan_id': '10'},
 {'interfaces': [], 'name': 'Test2', 'status': 'suspended', 'vlan_id': '20'},
 {'interfaces': [], 'name': 'VLAN0030', 'status': 'suspended', 'vlan_id': '30'}]

FragmentedPacket and others added 30 commits November 11, 2019 07:42
@FragmentedPacket
bug_fix: cisco_ios_show_interfaces_switchport - accounted more data
2fa9ee6
@bobbytayar @FragmentedPacket
new_template: cisco_ios_show_environment_temperature.template
03f50fe
@jmcgill298
Update state transitions to provide more consistency across platforms (…
5d93e50 
…networktocode#541)
@timjsmith24 @jmcgill298
New Template: WLC - show interface summary (networktocode#539)
07b69a6
@jmcgill298
Update CHANGELOG and bump version (networktocode#542)
f46bca2
@jmcgill298
Enhancement: Testing - Add Black to tox file for code formatting (net…
2155b1a 
…worktocode#407)
@jmcgill298
Enhancement: Add yamllint to tox testing (networktocode#406)
8298de4 
* Rename all parsed files to use ``.yml`` extension
* Add ``.yamllint`` file
* Add test in ``tox.ini`` file to run yamllint
* Add cli tool to format YAML files using ``ruamel``
* Reformat parsed files to adhere to preferred YAML style
* Add dev install option to package in setup.py
@FragmentedPacket @jmcgill298
Enhancement: Clean up test cases (networktocode#551)
f835e75
@jmcgill298
Enhancement: Use ".textfsm" extension for IDEs (networktocode#543)
3f78187
@jvanderaa @jmcgill298
BugFix: Added new regex match for additional output data
d354a69
@ewmanthei @jmcgill298
Enhancement: IOS lldp neighbors - add capabilities capture group (net…
1c1bb78 
…worktocode#553)
@afoster213 @jmcgill298
New Template: IOS - show logging (networktocode#554)
f88beb1
@jmcgill298 @jmorello12
Enhancement: IOS show int switchport - Add ADMIN_MODE Group (networkt…
7565931 
…ocode#563)

* Captured Administrative Mode, added support for unassigned Access VLAN

* Avoid trailing spaces and updated tests

Co-authored-by: jmorello12 <[email protected]>
@afoster213 @jmcgill298
New Template: ASA - Show Logging (networktocode#562)
581b0dc
@dgarros @jmcgill298
New Template: NXOS - show_interface_transceiver (networktocode#564)
34cac48
@migueloangelo @jmcgill298
BugFix: IOS show license - avoid trailing spaces (networktocode#565)
bcba5cf
@migueloangelo @jmcgill298
New Template: Cisco XR - show arp (networktocode#567)
086aec7
@FragmentedPacket
Add SERIAL to Cisco IOS LLDP Neighbors Detail (networktocode#572)
8de43e2 
Work done by danielolson13
@FragmentedPacket
New Template: Show arp - ASA (networktocode#573)
8f221a5
@FragmentedPacket
BugFix: NXOS show version - Add n5k platform regex (networktocode#575)
bf33650
@FragmentedPacket
New Templates: Fortinet get system interface and status (networktocod…
5a516d0 
…e#578)
@FragmentedPacket
Bug Fix: ASA Show failover - Account for new data (networktocode#574)
199a7c3
@kwrobert @FragmentedPacket
Bug Fix: cisco ios show mac address-table - skip multicast table (net…
ed45c4e 
…worktocode#577)
@FragmentedPacket @jmcgill298
New Template: Huawei display lldp neighbor (networktocode#576)
a354fb5
@FragmentedPacket @jmcgill298
New Template: Cisco WLC show wlan summary (networktocode#581)
1b90f05
@hijm @FragmentedPacket
New Template Pull Request - cisco_xr_show_interfaces_summary (network…
7f46977 
…tocode#580)
@jmcgill298
BugFix: NXOS show int transciever - remove "type" requirement (networ…
bb570c3 
…ktocode#582)
@kwrobert
Bug Fix: Cisco IOS show mac address-table (networktocode#585)
c8bc3ec
@kwrobert
Bug Fix: IOS sh int switchport - capture additional output (networkto…
4e0a8d6 
…code#587)
@msom
BugFix: Cisco show switch detail with mac persistency wait time (netw…
fda44b3 
…orktocode#584)
h4ndzdatm0ld and others added 17 commits March 11, 2021 18:24
@h4ndzdatm0ld
New Template: alcatel_sros_show_router_rsvp_interface (networktocode#884
3f13282 
)
@jmcgill298
Release v1.7.0 (networktocode#889)
78caab7
@jmcgill298
Migrate packaging to use poetry (networktocode#882)
4d4e268
@jmcgill298
Release v2.0.0 (networktocode#890)
31f194a
@h4ndzdatm0ld
New Template: alcatel_sros_show_service_sdp-using.textfsm (networktoc…
eabcf89 
…ode#891)
@jeffkala
add new template show port-security interface (networktocode#885)
5e56aaa
@QuasarKid
New Template: ruckus_fastiron, show mac-address (networktocode#896)
4606428
@FragmentedPacket
Bugfix: Type for cisco_nxos_show_interface_status (networktocode#880)
080fa3d
@QuasarKid
New Template: ruckus_fastiron, show interfaces brief (networktocode#895)
7bbc03c
@h4ndzdatm0ld
New Template: alcatel_sros_show_service_sap-using.textfsm (networktoc…
07efe9a 
…ode#892)
@h4ndzdatm0ld
New Template: alcatel_sros_show_router_mpls_lsp.textfsm (networktocod…
c47d469 
…e#893)
@jmcgill298
ruckus_fastiron_show_mac-address.textfsm - Add end of line for matchi…
bde563b 
…ng empty lines (networktocode#897)
@h4ndzdatm0ld
New template: alcatel_sros_show_router_interface.textfsm (networktoco…
f5b2d86 
…de#898)
@QuasarKid
New Template: ruckus_fastiron_show_version.textfsm (networktocode#894)
32bb2c3
@FragmentedPacket
Added deploy option to auto deploy on tags (networktocode#901)
8883fc3
@FragmentedPacket
Added Known Issues section to document Micah's finding/issue (network…
6f10c20 
…tocode#902)
@bravindranath-bsn
Modified arista_eos_show_vlan to list Ports issue networktocode#908
6eee42c
@itdependsnetworks itdependsnetworks mentioned this pull request Dec 3, 2022
Closed
@jmcgill298 jmcgill298 mentioned this pull request Dec 19, 2022
Merged
@jmcgill298
Copy link
Contributor

replaced by #1248

@jmcgill298 jmcgill298 closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FragmentedPacket FragmentedPacket Awaiting requested review from FragmentedPacket

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
jacob-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arista_eos_show_vlan template does not capture the list of interfaces part of the vlan