New Template Pull Request - cisco_xr_show_interfaces_summary #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ios xr - show interfaces summary
ios xr - show interfaces summary
- Index file chaged - Change the template structure (more generic) - Generation of yml file. (I did tests with my own code and the tempalte is working. But the generation with "python3 development_scripts.py -c tests/cisco_xr/show_interfaces_summary/cisco_xr_show_interfaces_summary.raw" was not generating entries inside of the yml. - The tox command was returning some errors not related with the new template.
FragmentedPacket
suggested changes
Jan 24, 2020
tests/cisco_xr/show_interfaces_summary/cisco_xr_show_interfaces_summary.yml
Outdated
Show resolved
Hide resolved
FragmentedPacket
added
changes_requested
- Changed ALL_TYPES value for INTF_TYPE value - Add some new validations
hijm
commented
Jan 24, 2020
There was a problem hiding this comment.
Aproved some required changes on the template. I will keep the "hard coded" validation for the interface types because this is the expected output as I saw in other templates related with status of the interfaces.
I am using the templates here, just giving back 👍
hijm
commented
Jan 24, 2020
FragmentedPacket
suggested changes
Jan 25, 2020
|
@hijm I believe you need to update tests/cisco_xr/show_interfaces_summary/cisco_xr_show_interfaces_summary.yml with the expected parsed data. |
FragmentedPacket
approved these changes
Jan 25, 2020
|
Thank you. |
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
SUMMARY
Here the output for the new cisco_xr_show_interfaces_summary.textfsm
Here the output using the same python script against existing "cisco_xr_show_interface_brief.textfsm"
tox.log