Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump the version of netlify-plugin-inline-functions-env #151

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

bencao
Copy link
Contributor

@bencao bencao commented Sep 23, 2020

The updates include a new input named "buildEvent". Details can be viewed on https://github.com/bencao/netlify-plugin-inline-functions-env/blob/master/CHANGELOG.md.

Thanks for contributing the Netlify plugins directory!

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plans

Also unit test is introduced and included in https://github.com/bencao/netlify-plugin-inline-functions-env/blob/master/test/index.test.js

@netlify-bot
Copy link
Collaborator

netlify-bot commented Sep 23, 2020

@ehmicky ehmicky self-requested a review September 24, 2020 11:50
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bencao,

Thanks!
It looks like 1.0.5 is not including the utils.functions.list() change. This can be shown in the diff here but also when installing the plugin locally.
Would it be possible to make a 1.0.6 release that includes it? Thanks!

the new version includes:
- a new option to include/exclude certain environment variables
- some internal refactoring
@bencao
Copy link
Contributor Author

bencao commented Oct 12, 2020

@ehmicky Just published 1.0.6 with utils.functions.list() change and two more feature flags. Test plan updated to point to the new test deployment for 1.0.6.

@ehmicky
Copy link
Contributor

ehmicky commented Oct 12, 2020

Hi @bencao, thanks a lot!
1.0.6 is accidentally removing support for Node 10 users. I have added an issue for it here.

update netlify-plugin-inline-functions-env to 1.0.8
@bencao
Copy link
Contributor Author

bencao commented Nov 4, 2020

@ehmicky v1.0.8 which fixed previous regression and also added test pipelines for multiple node versions were published.

@ehmicky ehmicky self-requested a review November 4, 2020 13:56
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ehmicky ehmicky merged commit 44cbb5b into netlify:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants