Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify's version of this package is outdated (still on 1.0.4) #15

Closed
dabrady opened this issue Oct 12, 2020 · 7 comments
Closed

Netlify's version of this package is outdated (still on 1.0.4) #15

dabrady opened this issue Oct 12, 2020 · 7 comments

Comments

@dabrady
Copy link

dabrady commented Oct 12, 2020

In my package.json, I have the latest version of this plugin installed, which is v1.0.5:

  "devDependencies": {
    ...
    "netlify-plugin-inline-functions-env": "^1.0.5",
    ...
  }

And everything was working fine on my deploy previews. But as soon as I tried a production deploy, the build failed because I'm using the buildEvent input, which was added in v1.0.5, but for some reason Netlify is using v1.0.4:
image

My guess is that since I do not have this plugin as a production dependency, Netlify is falling back to whatever version is in it's own plugin repository, and I'm guessing that version is out of date.

My current workaround has been to make this a production dependency, which allows it to take precedence over whatever is in Netlify's repository, and works:
image

@bencao
Copy link
Owner

bencao commented Oct 12, 2020

Thanks for reporting!
I just published a new version of 1.0.6 and will request an updated in netlify's plugin repo and it will become the default version that netlify use.

@bencao
Copy link
Owner

bencao commented Oct 12, 2020

This is the related PR in netlify/plugins repo netlify/plugins#151

@dabrady
Copy link
Author

dabrady commented Oct 12, 2020

Thanks a lot! 🙏

@tysonmatanich
Copy link

@bencao looks like Netlify is waiting on you to resolve a Node 10 compatibility issue #16.

@tysonmatanich
Copy link

🎉 Netlify now has 1.0.8. Issue should be able to be closed.

@bencao
Copy link
Owner

bencao commented Nov 6, 2020

since netlify already merged the version upgrade PR, this issue may be considered as done ,although I noticed the recent runs for my projects still uses v1.0.4.

@ehmicky would you mind help clarify when would the new version take effect in production for all projects that did not add the plugin to their devDependencies?

@ehmicky
Copy link
Collaborator

ehmicky commented Nov 6, 2020

Hi @bencao!
At the moment, new plugin versions are released each time we make a new release of our build system, which is typically around once per week, so this should be updated soon. We are also currently working on possible solutions to remove this delay altogether so that users get the new plugin version as soon as you've updated its version in netlify/plugins.

@bencao bencao closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants