Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): windows node 20 regression #6568

Merged
merged 4 commits into from
May 9, 2024
Merged

chore(ci): windows node 20 regression #6568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bc96f6
chore(ci): windows node 20 regression
JGAntunes May 9, 2024
d9cad84
chore(ci): fix the integration tests too
JGAntunes May 9, 2024
bc47bab
chore(ci): windows and node 22 don't play along in the integration tests
JGAntunes May 9, 2024
40e1825
chore: done with retrying macos test suite, failing test is flaking a…
JGAntunes May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ jobs:
strategy:
matrix:
os: [windows-latest]
node-version: ['18.14.0', '20']
# Temporary workaround due to this https://github.com/nodejs/node/issues/52682
# node-version: ['18.14.0', '20', '22']
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
node-version: ['18.14.0', '20.12.2', '22']
fail-fast: false

steps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: ['18.14.0', '20', '22']
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
node-version: ['18.14.0', '20.12.2', '22']
shard: ['1/4', '2/4', '3/4', '4/4']

exclude:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/framework-detection.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe.concurrent('frameworks/framework-detection', () => {
// This test has a race condition that occasionally causes it to fail when run concurrently.
// Running it in isolation (or removing the '.concurrent' on the describe block above)
// fixes it. See CT-1094 for more details
test('should log the command if using static server and `command` is configured', async (t) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above ☝️ test is prevent us from releasing this so skipping it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's a PR from @mrstork to address this - https://github.com/netlify/cli/pull/6564/files. We can probably follow up there 👍

test.skip('should log the command if using static server and `command` is configured', async (t) => {
await withSiteBuilder('site-with-index-file', async (builder) => {
await builder
.withContentFile({
Expand Down
Loading