chore(ci): windows node 20 regression #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo
previously approved these changes
May 9, 2024
paulo
previously approved these changes
May 9, 2024
paulo
previously approved these changes
May 9, 2024
…nd is known, skipping it
JGAntunes
commented
May 9, 2024
| @@ -69,7 +69,7 @@ describe.concurrent('frameworks/framework-detection', () => { | |||
| // This test has a race condition that occasionally causes it to fail when run concurrently. | |||
| // Running it in isolation (or removing the '.concurrent' on the describe block above) | |||
| // fixes it. See CT-1094 for more details | |||
| test('should log the command if using static server and `command` is configured', async (t) => { | |||
There was a problem hiding this comment.
See comment above ☝️ test is prevent us from releasing this so skipping it.
There was a problem hiding this comment.
Seems like there's a PR from @mrstork to address this - https://github.com/netlify/cli/pull/6564/files. We can probably follow up there 👍
paulo
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Caught as part of - #6565 - seems like there's a regression on latest node 20 which doesn't npm in the release see:
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)