Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6912: Fix static asset references when BASE_PATH is in use #6933

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Fixes #6912: Fix static asset references when BASE_PATH is in use #6933

merged 1 commit into from
Aug 12, 2021

Conversation

jeremystretch
Copy link
Member

Fixes: #6912

  • Remove the publicPath bundle option so that relative paths are used for all static assets

thatmattlove
thatmattlove approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@thatmattlove thatmattlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell in my local tests, this doesn't cause any issues. It's odd, I remember having to add it in order to get source maps to be referenced properly, but hey, it works.

@jeremystretch jeremystretch merged commit 1b074d2 into feature Aug 12, 2021
@jeremystretch jeremystretch deleted the 6912-static-resources branch August 12, 2021 19:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thatmattlove thatmattlove thatmattlove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @thatmattlove