some static files not found when BASE_PATH is changed

[nolta]

NetBox version

v3.0-beta1

Python version

3.8

Steps to Reproduce

1. Set BASE_PATH = 'netbox/'
2. Run upgrade.sh.
3. Load site in browser.

Expected Behavior

All static asset files should be found.

Observed Behavior

Some static files cannot be found (i.e., 404 errors).

For example, the site tries to load /static/netbox.js.map instead of /netbox/static/netbox.js.map. The problem appears to be this line:

netbox/netbox/project-static/dist/netbox.js

Line 67 in 6845fb0

//# sourceMappingURL=/static/netbox.js.map

Perhaps due to this?

netbox/netbox/project-static/bundle.js

Line 11 in 6845fb0

publicPath: '/static',

Changing sourceMappingURL=/static/netbox.js.map to sourceMappingURL=netbox.js.map appears to work, at least for this particular file.

[jeremystretch]

I don't have any issues loading Javascript resources using the current feature build with a non-default BASE_PATH, however I do see that the Material Design Icons font is being hard-coded to /static/. It also looks like we're pulling the Inter font from fonts.gstatic.com instead of locally.

[m2martin]

Shouldn't it be avoided to have mixed sources (local statics and external includes)?
In case of the font, this shouldn't cause any problems, as the Open Fonts License for Inter grants copying, embedding and redistributing.
Background: I do have Netbox instances where the clients are not allowed to access external resources.
What's your opinion?

[jeremystretch]

Shouldn't it be avoided to have mixed sources (local statics and external includes)?

Yes; NetBox is designed to deliver all static assets locally, to support installations with no Internet access.