Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17406 allow deletion of plugin custom field if plugin removed #17491

Merged
merged 2 commits into from
Sep 17, 2024
Merged

17406 allow deletion of plugin custom field if plugin removed #17491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a2100
17406 allow deletion of plugin custom field if plugin removed
arthanson Sep 13, 2024
f9568ff
17406 allow deletion of plugin custom field if plugin removed
arthanson Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions netbox/extras/models/customfields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,11 @@ def remove_stale_data(self, content_types):
no longer assigned to a model, or because it has been deleted).
"""
for ct in content_types:
model = ct.model_class()
instances = model.objects.filter(custom_field_data__has_key=self.name)
for instance in instances:
del instance.custom_field_data[self.name]
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)
if model := ct.model_class():
instances = model.objects.filter(custom_field_data__has_key=self.name)
for instance in instances:
del instance.custom_field_data[self.name]
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)

def rename_object_data(self, old_name, new_name):
"""
Expand Down