Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17406 allow deletion of plugin custom field if plugin removed #17491

Merged
merged 2 commits into from
Sep 17, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
17406 allow deletion of plugin custom field if plugin removed
arthanson committed Sep 13, 2024
commit f9568ff4f6b120f1eb5d083c50a421130d1f6af0
3 changes: 1 addition & 2 deletions netbox/extras/models/customfields.py
Original file line number Diff line number Diff line change
@@ -294,8 +294,7 @@ def remove_stale_data(self, content_types):
no longer assigned to a model, or because it has been deleted).
"""
for ct in content_types:
model = ct.model_class()
if model:
if model := ct.model_class():
instances = model.objects.filter(custom_field_data__has_key=self.name)
for instance in instances:
del instance.custom_field_data[self.name]