Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15917: slim-select-pagination-bug-fix : fixed several bugs related to slim select #15918

Merged
merged 2 commits into from
May 3, 2024

Conversation

MaxBear
Copy link
Contributor

@MaxBear MaxBear commented May 2, 2024

Fixes: #15917

  1. introduce internal state variable searchKey
  2. add render() in handleSearch() function
  3. call handleSearch() when atbottom event is triggered
  4. call handleSearch() after refresh button is clicked

select search box gui element
1. If user enters a search text in the filter text box, the user will
   not be able to scroll to the next page. That is the user will only be
   able to see the first page of returned item with a none empty search
   string.
2. User will not be able to select an item returned from search query
   if user clicks reload after a dynami search. When the user is able
   to load a second page, the user will be able to select an item from
   the third+ page if previous bug is fixed.
@MaxBear MaxBear changed the title Fixes #15917: slim-select-pagination-bug-fix : fixed several bugs related to slim Fixes #15917: slim-select-pagination-bug-fix : fixed several bugs related to slim select May 2, 2024
@arthanson
Copy link
Collaborator

This library has been completely removed in NB v4, so this would no longer apply.

@MaxBear Also, FYI - While we greatly appreciate the work here, please open the issue before submitting a PR, there may be discussion needed around any proposed solution or it may be superseded by other work.

@arthanson arthanson closed this May 3, 2024
@MaxBear
Copy link
Contributor Author

MaxBear commented May 3, 2024

@arthanson The issue and the fix still apply for users not upgraded to beta v4 release. I have already opened the issue , otherwise, i won't have the fix id . By this

here may be discussion needed around any proposed solution or it may be superseded by other work.

do you mean one should only submit a pr after you have decided to submit a pr for this fix or not ?

@arthanson
Copy link
Collaborator

@MaxBear Sorry, you submitted the issue at just the wrong time (no fault of yours) we just did the last release of 3.x before the 4.x release so there wasn't a release to get this in. That said, we are currently evaluating whether we might cut one more 3.x release and if we do we will re-evaluate potentially including your PR assuming there are not any changes needed.

@jeremystretch jeremystretch reopened this May 3, 2024
@jeremystretch jeremystretch merged commit 88f2735 into netbox-community:develop May 3, 2024
4 checks passed
jeremystretch added a commit that referenced this pull request May 6, 2024
…ated to slim select (#15918)

* slim-select-pagination-bug-fix : fixed several bugs related to slim
select search box gui element
1. If user enters a search text in the filter text box, the user will
   not be able to scroll to the next page. That is the user will only be
   able to see the first page of returned item with a none empty search
   string.
2. User will not be able to select an item returned from search query
   if user clicks reload after a dynami search. When the user is able
   to load a second page, the user will be able to select an item from
   the third+ page if previous bug is fixed.

* Recompile static assets

---------

Co-authored-by: Jeremy Stretch <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants