Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slim-select-pagination-bug : user not able to load more than one page of data after a text search in slim select search box #15917

Closed
MaxBear opened this issue May 1, 2024 · 6 comments · Fixed by #15918
Closed

slim-select-pagination-bug : user not able to load more than one page of data after a text search in slim select search box #15917

MaxBear opened this issue May 1, 2024 · 6 comments · Fixed by #15918
Assignees
@MaxBear
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@MaxBear
Copy link
Contributor

MaxBear commented May 1, 2024

Deployment Type

NetBox Cloud

NetBox Version

v3.7.7-dev

Python Version

3.11

Steps to Reproduce

  1. insert enough entries in extras_tag table such that for a search string "x" there are more than 50 (default max page size) items returned
  2. open edit page for a dcim device interface
  3. open tag dialogue box which uses a slim select GUI control under the hood, enter search string "x" in the filter search box
  4. scroll down to the bottom of the returned list
  5. notice you cannot get more items behind the first page of returned items although an api call to the next page is already made

Expected Behavior

When user reaches the end of currently returned list of items more items will be extended to the list if there are more.

Observed Behavior

Current behaviour is that user will not be able to go behind the first page of returned items.
@MaxBear MaxBear added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 1, 2024
@MaxBear
Copy link
Contributor Author

MaxBear commented May 1, 2024

correction: the deployment type is self-hosted

@MaxBear MaxBear mentioned this issue May 2, 2024
Merged
@arthanson arthanson added severity: low Does not significantly disrupt application functionality, or a workaround is available and removed type: bug A confirmed report of unexpected behavior in the application labels May 2, 2024
@arthanson
Copy link
Collaborator

@MaxBear I see you have a PR in for this so assigning it to you.

@MaxBear
Copy link
Contributor Author

MaxBear commented May 2, 2024

Thanks @arthanson have you had a chance to code review my pr ?

@arthanson arthanson removed the status: needs triage This issue is awaiting triage by a maintainer label May 2, 2024
@arthanson arthanson removed their assignment May 2, 2024
@arthanson
Copy link
Collaborator

Actually @MaxBear this library has been completely removed in NB v4, so this would no longer apply. Going to close this.

@MaxBear
Copy link
Contributor Author

MaxBear commented May 3, 2024

@arthanson we are still on v.3.4.10 for our netbox installation. Will my fix still be looked at and included in a patch release ?

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels May 3, 2024
@jeremystretch jeremystretch reopened this May 3, 2024
@jeremystretch
Copy link
Member

Re-opening this for review as it looks like we'll end up cutting a v3.7.8 release for some unrelated bug fixes.

jeremystretch added a commit that referenced this issue May 3, 2024
@MaxBear @jeremystretch
Fixes #15917: slim-select-pagination-bug-fix : fixed several bugs rel…
88f2735 
…ated to slim select (#15918)

* slim-select-pagination-bug-fix : fixed several bugs related to slim
select search box gui element
1. If user enters a search text in the filter text box, the user will
   not be able to scroll to the next page. That is the user will only be
   able to see the first page of returned item with a none empty search
   string.
2. User will not be able to select an item returned from search query
   if user clicks reload after a dynami search. When the user is able
   to load a second page, the user will be able to select an item from
   the third+ page if previous bug is fixed.

* Recompile static assets

---------

Co-authored-by: Jeremy Stretch <[email protected]>
jeremystretch added a commit that referenced this issue May 3, 2024
@jeremystretch
Changelog for #15877, #15917, #15925
c6f833e
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
jeremystretch added a commit that referenced this issue May 6, 2024
@MaxBear @jeremystretch
Fixes #15917: slim-select-pagination-bug-fix : fixed several bugs rel…
a544b55 
…ated to slim select (#15918)

* slim-select-pagination-bug-fix : fixed several bugs related to slim
select search box gui element
1. If user enters a search text in the filter text box, the user will
   not be able to scroll to the next page. That is the user will only be
   able to see the first page of returned item with a none empty search
   string.
2. User will not be able to select an item returned from search query
   if user clicks reload after a dynami search. When the user is able
   to load a second page, the user will be able to select an item from
   the third+ page if previous bug is fixed.

* Recompile static assets

---------

Co-authored-by: Jeremy Stretch <[email protected]>
jeremystretch added a commit that referenced this issue May 6, 2024
@jeremystretch
Changelog for #15877, #15917, #15925
ed7a0a3
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MaxBear MaxBear

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
3 participants
@arthanson @MaxBear @jeremystretch