14947 fix for missing changelog if only update m2m #14986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Feb 2, 2024
netbox/extras/signals.py
Outdated
Comment on lines
78
to
87
| if not qs: | ||
| objectchange = instance.to_objectchange(action) | ||
| if objectchange and objectchange.has_changes: | ||
| objectchange.user = request.user | ||
| objectchange.request_id = request.id | ||
| objectchange.save() | ||
| else: | ||
| qs.update( | ||
| postchange_data=instance.to_objectchange(action).postchange_data | ||
| ) |
There was a problem hiding this comment.
We can clean this up a bit using the update_or_create() queryset method to automatically create a new change record where needed. We can also pull objectchange = instance.to_objectchange(action) up to the top, as it appears to be needed under every condition.
There was a problem hiding this comment.
I moved the objectchange = line.
For update_or_create I don't think that would be any cleaner as on create you are doing objectchange.save and not specifying all the fields. For update_or_create you would need to specify all the fields for defaults and create_defaults which is sort of duplicating instance.to_objectchange.
jeremystretch
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14947
Fix for missing changelog if only update m2m (tag). Issue is if you only update tags (no other edits) then the changelog entry for the post_save (not m2m_changed) is not created because there are no changes at that point. When the m2m_changed comes in the update does not work because the query is empty.
Fix is if there is an m2m change and there isn't an existing objectchange then create one, otherwise do the update.