Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog entry missing for tag change #14947

Closed
kuhball opened this issue Jan 26, 2024 · 1 comment · Fixed by #14986
Closed

Changelog entry missing for tag change #14947

kuhball opened this issue Jan 26, 2024 · 1 comment · Fixed by #14986
Assignees
@arthanson
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@kuhball
Copy link

kuhball commented Jan 26, 2024 •
edited
Loading

Deployment Type

Self-hosted

NetBox Version

v3.7.1

Python Version

3.11

Steps to Reproduce

  1. Edit an Interface / Device / Site
  2. Add / remove a tag

Reproducible within demo.netbox.dev.

Expected Behavior

After adding / removing the tag I would expect to see a changelog entry.

Observed Behavior

No changelog entry is created.
@kuhball kuhball added the type: bug A confirmed report of unexpected behavior in the application label Jan 26, 2024
@kuhball kuhball changed the title Changelog entry missing for tag change on interface Changelog entry missing for tag change Jan 26, 2024
@jeremystretch
Copy link
Member

jeremystretch commented Jan 26, 2024 •
edited
Loading

Seems like a regression introduced in v3.7.0 by #14147.

Setting CHANGELOG_SKIP_EMPTY_CHANGES = False works around the bug.

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows labels Jan 26, 2024
@arthanson arthanson self-assigned this Jan 30, 2024
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 30, 2024
@arthanson arthanson mentioned this issue Jan 30, 2024
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Feb 2, 2024
@jeremystretch jeremystretch mentioned this issue Feb 5, 2024
Merged
@arthanson arthanson mentioned this issue Feb 12, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

14947 fix for missing changelog if only update m2m netbox-community/netbox
3 participants
@arthanson @kuhball @jeremystretch