Fixes: #14840 - Forces API to use django user model instead of proxy model

[DanSheps]

Fixes: #14840 - Forces API to use django user model instead of proxy model

• Swap the model name in get_viewname for only NetBoxUser and NetBoxGroup

[DanSheps]

I think this will be a much more acceptable resolution to the problem, it does introduce another API endpoint (but maintains all the filters from /users/, I couldn't find a clean way of customizing the "basename" without modifying NetBoxRouter).

Alternatively, we could swap the proxy model in the ContentTypeManager for the actual user model

[jeremystretch]

We shouldn't add a redundant API endpoint for the same model. Instead, we can tweak the logic in get_viewname() to resolve the view for the concrete model (User) instead of the proxy model (NetBoxUser). There are a few other places where we use proxy models though, so we'll need to check that those are not broken as a result of this change.

Ultimately this problem should be side-stepped by the introduction of a proper custom user model in v4.0 under #12795.

[DanSheps]

We shouldn't add a redundant API endpoint for the same model. Instead, we can tweak the logic in get_viewname() to resolve the view for the concrete model (User) instead of the proxy model (NetBoxUser). There are a few other places where we use proxy models though, so we'll need to check that those are not broken as a result of this change.

You are absolutely correct, that is a much easier way to handle that. Made a tweak to swap the proxy model to the user model and it looks to be good now.

[jeremystretch]

This doesn't appear to fully resolve #14840. Although you can now edit an object with a custom field pointing to the User model, attempting to save it raises a SerializerNotFound exception:

Could not determine serializer for users.NetBoxUser with prefix 'Nested'

[jeremystretch]

Thanks @DanSheps!