Fixes #13033: add formatted speed column to Interfaces #13275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Jul 28, 2023
|
Thanks @matejv! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13033
Adds a new column to Interface table where interface speed is passed through humanize_speed & placeholder filters. I've opted to have placeholder filter, since almost all other
InterfaceTablecolumns have it.To keep CSV export looking OK I had to sub-class
TemplateColumnand overridevalue()method. This way we can keep formatted values in CSV exports (it didn't make sense to me to have un-formatted value, since we're keeping the original speed column). And have empty values in CSV export be empty and not filled with—placeholders.