Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add formatted speed column to interface lists #13033

Closed
matejv opened this issue Jun 28, 2023 · 2 comments · Fixed by #13275
Closed

add formatted speed column to interface lists #13033

matejv opened this issue Jun 28, 2023 · 2 comments · Fixed by #13275
Assignees
@matejv
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@matejv
Copy link
Contributor

matejv commented Jun 28, 2023

NetBox version

v3.5.4

Feature type

New functionality

Proposed functionality

I propose adding a new column Speed to InterfaceTable that would show interface speed but formatted the same way it is shown on interface details view. This column would be added in addition of existing column Speed (kbps).

It would not be shown by default. Users could choose the column to be shown to show speed ether in kbps as now or shown formatted as 10 Gbps...

Use case

Currently it is difficult to determine if a speed is set to 1G, 10G or 100G without carefully counting if there are 6, 7 or 8 zeroes after 1.

image

With this change:

image

Database changes

None

External dependencies

None
@matejv matejv added the type: feature Introduction of new functionality to the application label Jun 28, 2023
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jul 26, 2023
@jeremystretch
Copy link
Member

Just to reiterate, this would introduce a new column, leaving the current column in place. The existing column works better for programmatic consumption; the new column better serves human readability.

@matejv
Copy link
Contributor Author

matejv commented Jul 26, 2023 •
edited
Loading

That is correct.

I can take this if it's OK, as I already have the modifications made locally.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jul 26, 2023
matejv added a commit to matejv/netbox that referenced this issue Jul 26, 2023
@matejv
Fixes netbox-community#13033: add formatted speed column to Interfaces
59e6578
@matejv matejv mentioned this issue Jul 26, 2023
Merged
jeremystretch pushed a commit that referenced this issue Aug 2, 2023
@matejv
Fixes #13033: add formatted speed column to Interfaces (#13275)
a807cca 
* Fixes #13033: add formatted speed column to Interfaces

* use TemplateColumn instead of own class
jeremystretch added a commit that referenced this issue Aug 4, 2023
@jeremystretch
Changelog for #12750, #12889, #13033, #13151, #13343, #13369
88562d7
@jeremystretch jeremystretch mentioned this issue Aug 15, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matejv matejv

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #13033: add formatted speed column to Interfaces matejv/netbox
2 participants
@matejv @jeremystretch