Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links within embedded tables do not load when HTMX is enabled #15637

Closed
julianstolp opened this issue Apr 5, 2024 · 3 comments
Closed

Links within embedded tables do not load when HTMX is enabled #15637

julianstolp opened this issue Apr 5, 2024 · 3 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@julianstolp
Copy link

julianstolp commented Apr 5, 2024 •
edited by jeremystretch
Loading

Deployment Type

Self-hosted

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Go to user preferences and enable HTMX Navigation
  2. Go to a site and attach an image
  3. Click on the parent of that image, which should be the site itself
  4. Opens the card Site and Custom Fields within Images

Expected Behavior

It opens the site in the same tab like every other link.

Observed Behavior

error1
@julianstolp julianstolp added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 5, 2024
@julianstolp
Copy link
Author

And in addition, the edit button does not work. The dropdown menu is also displayed in the card body instead of beyond the edge of the card.

image

@jeremystretch jeremystretch removed their assignment Apr 5, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation topic: UI/UX User interface or user experience related work severity: low Does not significantly disrupt application functionality, or a workaround is available beta Concerns a bug/feature in a beta release and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 5, 2024
@jeremystretch jeremystretch self-assigned this Apr 5, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 5, 2024
@jeremystretch
Copy link
Member

The dropdown menu is also displayed in the card body instead of beyond the edge of the card.

Tagging #15536 as the same fix is likely needed here.

@jeremystretch jeremystretch changed the title image attachment opens link in card itself Links within embedded tables do not load when HTMX is enabled Apr 5, 2024
@jeremystretch
Copy link
Member

Changed the issue title as this seems to impact all embedded tables, not just image attachments.

@jeremystretch jeremystretch mentioned this issue Apr 5, 2024
Merged
jeremystretch added a commit that referenced this issue Apr 5, 2024
@jeremystretch
Fixes #15637: Fix rendering of links from within embedded tables w/HT…
d34f188 
…MX enabled (#15642)

* Add htmx_table to __all__

* Fix dropdown menu clipping

* Fix loading links from within embedded tables

* Fix rendering of object deletion warning
@jeremystretch jeremystretch mentioned this issue Apr 8, 2024
Closed
jeremystretch added a commit that referenced this issue Apr 11, 2024
@jeremystretch
Changelog for #15605, #15616, #15617, #15619, #15637, #15638
379fe7c
@jeremystretch jeremystretch mentioned this issue Apr 15, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremystretch @julianstolp