Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working custom links not visible in dark mode #15616

Closed
julianstolp opened this issue Apr 4, 2024 · 0 comments
Closed

Not working custom links not visible in dark mode #15616

julianstolp opened this issue Apr 4, 2024 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@julianstolp
Copy link

Deployment Type

Self-hosted

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Create a not working Custom Link on any model eg:
    image
  2. Go to Model Device in light mode
    image
  3. Toggle to darkmode, see nothing
    image
  4. Do mousehover
    image

Expected Behavior

Button switches class to class="btn btn-sm btn-outline-light"
image

Observed Behavior

Button does not switch class="btn btn-sm btn-outline-dark"

<a class="btn btn-sm btn-outline-dark" disabled="disabled" title="'dcim.models.devices.Device object' has no attribute 'device_role'"><i class="mdi mdi-alert"></i> Test</a>
@julianstolp julianstolp added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 4, 2024
@jeremystretch jeremystretch changed the title [Beta] Not working custom links not visible in dark mode Not working custom links not visible in dark mode Apr 4, 2024
@jeremystretch jeremystretch removed their assignment Apr 4, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available beta Concerns a bug/feature in a beta release topic: UI/UX User interface or user experience related work and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 4, 2024
@jeremystretch jeremystretch self-assigned this Apr 5, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 5, 2024
jeremystretch added a commit that referenced this issue Apr 5, 2024
@jeremystretch
Fixes #15616: Tweak button class for invalid custom links
25c39ce
jeremystretch added a commit that referenced this issue Apr 11, 2024
@jeremystretch
Changelog for #15605, #15616, #15617, #15619, #15637, #15638
379fe7c
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremystretch @julianstolp