-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source for Amazon S3 being able to accept S3 compatible server #15427
Labels
status: accepted
This issue has been accepted for implementation
type: feature
Introduction of new functionality to the application
Comments
javierdelapuente
added
the
type: feature
Introduction of new functionality to the application
label
Mar 14, 2024
jeremystretch
added
the
status: needs triage
This issue is awaiting triage by a maintainer
label
Mar 26, 2024
jeremystretch
added
status: needs owner
This issue is tentatively accepted pending a volunteer committed to its implementation
and removed
status: needs triage
This issue is awaiting triage by a maintainer
labels
Apr 3, 2024
@javierdelapuente would you like to own this? |
Yes, I would be pleased to help! |
jeremystretch
added
status: accepted
This issue has been accepted for implementation
and removed
status: needs owner
This issue is tentatively accepted pending a volunteer committed to its implementation
labels
Apr 15, 2024
@javierdelapuente thanks, I've assigned this to you. |
jeremystretch
added a commit
that referenced
this issue
Apr 17, 2024
jeffgdotorg
pushed a commit
to jeffgdotorg/netbox
that referenced
this issue
Apr 18, 2024
Merged
JCWasmx86
pushed a commit
to JCWasmx86/netbox
that referenced
this issue
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: accepted
This issue has been accepted for implementation
type: feature
Introduction of new functionality to the application
NetBox version
v3.7.4
Feature type
Change to existing functionality
Proposed functionality
Data sources of type
Amazon S3
do not work with compatible S3 servers. The proposal is to allow S3 compatible servers to be used as data sources.Currently, there is a datasource of type "Amazon S3", that uses Amazon S3 in AWS. When creating the data source, the URL protocol and domain/netloc are not taken into account (except to obtain the region), so by default only AWS can be used.
The proposal is to add the argument
endpoint_url
to construct the boto3.resource, so S3 compatible servers can be used. The proposed change will be located in here:netbox/netbox/core/data_backends.py
Line 147 in 4adb44f
As a workaround, environment variables can be used (like
AWS_ENDPOINT_URL
), but that limits all S3 data sources to reside in that url.Use case
This feature will allow NetBox users to use other cloud providers or to host their own S3 compatible servers instead of using AWS to store their scripts and reports for
Amazon S3
datasources.Database changes
None
External dependencies
None
The text was updated successfully, but these errors were encountered: