Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically clear dependent selection fields when modifying a parent selection #14237

Closed
jeremystretch opened this issue Nov 9, 2023 · 3 comments
Closed

Automatically clear dependent selection fields when modifying a parent selection #14237

jeremystretch opened this issue Nov 9, 2023 · 3 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.6.4

Feature type

Change to existing functionality

Proposed functionality

When selecting a different option of a selection field, any dependent selection fields should be reset. For example, when editing a device which currently assigned to a site and location, changing the value of the site field in the form should clear the value of the location field.

Use case

This will avoid user confusion by making it clear that the previously populated selection in the dependent field is no longer valid and a new selection must be made (where applicable).

Database changes

No response

External dependencies

No response
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 9, 2023
@jeremystretch jeremystretch mentioned this issue Nov 9, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Feb 8, 2024
@jeremystretch
Copy link
Member Author

Now that #14917 is wrapping up, this is something we should revisit in v4.0.

@jeremystretch jeremystretch self-assigned this Feb 8, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Feb 8, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Feb 8, 2024
jeremystretch added a commit that referenced this issue Feb 8, 2024
@jeremystretch
Closes #14237: Clear child selections on change to parent selection
674f794
@jeremystretch
Copy link
Member Author

This ended up being a trivial change, so I've bundled it with #14917 in PR #15080.

jeremystretch added a commit that referenced this issue Feb 8, 2024
@jeremystretch
Closes #14917: Replace slim-select with tom-select (#15080)
d63e1da 
* Experimenting

* Remove testing resources

* Replace ApiSelect with TomSelect

* Add color support

* Add clear button

* Clear cached options when searching dynamic selects

* Add support for static parameters

* Refactor TomSelect implementation

* Add dynamic parameter support

* Limit number of options to 100

* Remove redundant api_url definitions for user model

* Add support for disabled indicator

* Remove obsolete value-field attr on dynamic select widgets

* Remove obsolete fetch_trigger kwarg from dynamic model choice widgets

* Remove obsolete empty_label kwarg from dynamic model choice widgets

* Add support for API path variables

* Add support for setting a 'null' option

* Annotate depth for recursive hierarchies

* Misc cleanup

* Remove obsolete APISelect code

* Remove slim-select & just-debounce-it

* Clean up type validation

* Closes #14237: Clear child selections on change to parent selection

* Use an MD icon for the clear button

* Use an MD icon for the clear button

* Explain why noUnusedParameters is disabled
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch