Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cable edit not working #14234

Closed
ramyalexis opened this issue Nov 9, 2023 · 5 comments
Closed

Cable edit not working #14234

ramyalexis opened this issue Nov 9, 2023 · 5 comments

Comments

@ramyalexis
Copy link

ramyalexis commented Nov 9, 2023

NetBox version

3.6.4

Python version

3.8

Steps to Reproduce

Checked on demo site.

  1. Pick any device with connected cables
  2. Go to interface and edit cable from there.
  3. Pick NEW device (just pick random one) for cable endpoint but leave OLD interface
  4. Click save and observe "Success message"
    image
    image
    image

Expected Behavior

Cable endpoint changed. For example, you relink to the other switch, and it has same interface number, so device change should be enough without port change.
If this is not possible, generate an error. Like destination device does not have such port or something.
Do not fool user with success when no actual changes were made and it is in fact failed.

Observed Behavior

In reality - no change is made. Can be confirmed at looking at the device interfaces. Old cable stays the same
Confusing log with change but nothing changed. Technically log is correct. Indeed, noting changed. But why it is then here if this is change log?
image

@ramyalexis ramyalexis added the type: bug A confirmed report of unexpected behavior in the application label Nov 9, 2023
@ramyalexis
Copy link
Author

In addition, this trick will not work if after picking new device you also pick new interface.

@abhi1693
Copy link
Member

abhi1693 commented Nov 9, 2023

Device is not a discrete field on the cable model, it's provided for filtering purposes. So, the behaviour mentioned is expected.

@ramyalexis
Copy link
Author

ramyalexis commented Nov 9, 2023

I am not aware of technical internals, but the fact is this is not working "correct". At least from my point of view
In short - you change something. You got success message. Nothing changed. Does this sound ok?

@jeremystretch
Copy link
Member

@abhi1693 is correct: You changed the device field but did not make any change to the interface field. The device form field exists only to assist in filtering the interfaces list; changing it alone has no bearing on the assigned interface.

This in itself is not a bug, though I can see why it may be confusing. I've opened FR #14237 to propose a UI improvement to address this.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@jeremystretch jeremystretch removed the type: bug A confirmed report of unexpected behavior in the application label Nov 9, 2023
@kkthxbye-code
Copy link
Contributor

kkthxbye-code commented Nov 9, 2023

@jeremystretch

This in itself is not a bug, though I can see why it may be confusing. I've opened FR #14237 to propose a UI improvement to address this.

Maybe I'm misunderstanding, but I don't believe that FR would fix anything in this particular case. Cables can terminate on multiple interfaces on different devices. Clearing the multi-select cable termination field when changing the device would not really make sense.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants