Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete image attachment on device (type) should return to device not to image attachments list #12538

Closed
blindzero opened this issue May 10, 2023 · 0 comments · Fixed by #12721
Closed

Delete image attachment on device (type) should return to device not to image attachments list #12538

blindzero opened this issue May 10, 2023 · 0 comments · Fixed by #12721
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@blindzero
Copy link

NetBox version

v3.5.1

Feature type

Change to existing functionality

Proposed functionality

When deleting an attached image (picture) from a detail view of a device or device type you should return to the device / device type from which you started this.
A.t.m. you are coming to the list of image attachments and need to navigate back to the device.

Use case

Usability improvement as it is most likely that you are in the context of a specific device / device type you are maintaining and not the list of all image attachments.

Database changes

No response

External dependencies

No response
@blindzero blindzero added the type: feature Introduction of new functionality to the application label May 10, 2023
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed type: feature Introduction of new functionality to the application labels May 25, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 25, 2023
@abhi1693 abhi1693 self-assigned this May 25, 2023
abhi1693 added a commit that referenced this issue May 25, 2023
@abhi1693
fixes return_url for image attachment #12538
2bc8a97
@abhi1693 abhi1693 mentioned this issue May 25, 2023
Merged
@jeremystretch jeremystretch mentioned this issue May 31, 2023
Closed
jeremystretch added a commit that referenced this issue May 31, 2023
@abhi1693 @jeremystretch
Fixes return_url for image attachment (#12721)
dbd3c6d 
* fixes return_url for image attachment #12538

* simplified conditions

* handle nonetype error

* fixed request check

* Introduce htmx_table template tag for embedding HTMX-backed object tables

---------

Co-authored-by: jeremystretch <[email protected]>
jeremystretch added a commit that referenced this issue May 31, 2023
@jeremystretch
Changelog for #7503, #9876, #12015, #12538, #12762
852026b
@jeremystretch jeremystretch mentioned this issue Jun 2, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes return_url for image attachment netbox-community/netbox
3 participants
@abhi1693 @jeremystretch @blindzero