Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device type/role to Interface filter #12015

Closed
ty8berg opened this issue Mar 21, 2023 · 2 comments · Fixed by #12504
Closed

Add device type/role to Interface filter #12015

ty8berg opened this issue Mar 21, 2023 · 2 comments · Fixed by #12504
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@ty8berg
Copy link

ty8berg commented Mar 21, 2023

NetBox version

v3.4.4

Feature type

New functionality

Proposed functionality

Add the ability to filter interfaces by device types or device roles. I would like to review a set of devices that all fall under one device type or device role, and check whether a connection has been made to the interface. However, to do this, I have to search for each device individually and select every one into the filter to display what would be the same result if I could just filter by device type/role.

Use case

The use case for this would be reviewing and checking interfaces easily for specific device types or roles. More specifically, the ability to see cables and their connections for device types and roles.

Database changes

No response

External dependencies

No response
@ty8berg ty8berg added the type: feature Introduction of new functionality to the application label Mar 21, 2023
@jeremystretch jeremystretch changed the title Feature Request - Add device type/role to Interface filter Add device type/role to Interface filter May 4, 2023
@jeremystretch
Copy link
Member

If undertaken, this should be implemented consistently for all device components (not just interfaces).

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 4, 2023
@ty8berg
Copy link
Author

ty8berg commented May 4, 2023

Hi Jeremy,

Yes I agree, the ability to filter any of the device's components by device roles or device types would be highly beneficial

@abhi1693 abhi1693 self-assigned this May 5, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 5, 2023
abhi1693 added a commit that referenced this issue May 5, 2023
@abhi1693
adds device type and role to device component filter #12015
6d70f33
abhi1693 added a commit that referenced this issue May 5, 2023
@abhi1693
adds device type and role to device component filter #12015
ee80ab9
@abhi1693 abhi1693 mentioned this issue May 5, 2023
Merged
jeremystretch pushed a commit that referenced this issue May 9, 2023
@abhi1693 @jeremystretch
adds device type and role to device component filter #12015
20ad552
jeremystretch added a commit that referenced this issue May 31, 2023
@abhi1693 @jeremystretch
Adds device type and role to device component filter (#12504)
bd88ee7 
* adds device type and role to device component filter #12015

* changes as per review

* Add filterset tests for device type & role filters

---------

Co-authored-by: jeremystretch <[email protected]>
jeremystretch added a commit that referenced this issue May 31, 2023
@jeremystretch
Changelog for #7503, #9876, #12015, #12538, #12762
852026b
@jeremystretch jeremystretch mentioned this issue Jun 2, 2023
Merged
jeremystretch added a commit that referenced this issue Aug 28, 2023
@arthanson @abhi1693 @jeremystretch
12489 Use HTMX for Location and Non-Racked Devices in Site detail view (
29877c9 
#12491)

* 12489 use htmx for site view locations and non-racked-devices

* 12489 remove now unused queries in context

* adds device type and role to device component filter #12015

* Revert "Fixes #12463: Fix the association of completed jobs with reports & scripts in the REST API"

This reverts commit a29a07e.

* 12489 update nonracked_devices on rack and location templates

* 12489 fix whitespace issue

* Undo errant commits

* 12489 update site id in templates

* 12489 remove nonracked_devices include

* 12489 add has_position filter

* Use empty lookup for position field

* Remove non-racked devices list from rack view (was moved to a tab)

* Clean up location and device tables

* Restore plugins block on rack template

---------

Co-authored-by: Abhimanyu Saharan <[email protected]>
Co-authored-by: jeremystretch <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds device type and role to device component filter netbox-community/netbox
3 participants
@abhi1693 @jeremystretch @ty8berg