Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of rack reservation in elevations #11900

Closed
Wait4Code opened this issue Mar 3, 2023 · 0 comments · Fixed by #12506
Closed

Improve readability of rack reservation in elevations #11900

Wait4Code opened this issue Mar 3, 2023 · 0 comments · Fixed by #12506
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@Wait4Code
Copy link

NetBox version

3.4.3

Feature type

Change to existing functionality

Proposed functionality

Add some borders in SVG around rack reservations to better distinguish them (and maybe a sort of highlight on hover).
path tag can be used to solve this problem. For example, for the case described just after, this solution works :

<a xmlns="http://www.w3.org/2000/svg" target="_parent" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="xxx">
  <title>Reservation #14: CUSTOMER 1</title>
  <path d="M256,530 L271,530" style="stroke:  black;stroke-width: 2px;"/>
  <rect class="reservation" height="66" width="15" x="256" y="530"/>
  <path d="M256,596 L271,596" style="stroke:  black;stroke-width: 2px;"/>
</a>
<a xmlns="http://www.w3.org/2000/svg" target="_parent" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="xxx"> 
  <title>Reservation #13: CUSTOMER 2</title>
  <path d="M256,596 L271,596" style="stroke:  black;stroke-width: 2px;"/>
  <rect class="reservation" height="66" width="15" x="256" y="596"/>
  <path d="M256,662 L271,662" style="stroke:  black;stroke-width: 2px;"/>
</a>

Another idea (but I should maybe open another ticket for that) is to have a slighty different background on reservation representation when looking at it :
image

Use case

When there are many rack-reservation on a rack, elevation is not really readable because all reservations representations are sticked.
For example, in this one, there is one reservation between 13 and 15U and an other, just after, between 16 and 19U.

image

With borders (paths) :
image

Database changes

None.

External dependencies

No response

@Wait4Code Wait4Code added the type: feature Introduction of new functionality to the application label Mar 3, 2023
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 16, 2023
@abhi1693 abhi1693 self-assigned this May 5, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 5, 2023
abhi1693 added a commit that referenced this issue May 5, 2023
jeremystretch added a commit that referenced this issue May 9, 2023
* adds stroke to the reservation #11900

* fixed right side border

* Tweak reserved stroke style & add constants for colors

---------

Co-authored-by: jeremystretch <[email protected]>
jsenecal pushed a commit to jsenecal/netbox that referenced this issue May 18, 2023
* adds stroke to the reservation netbox-community#11900

* fixed right side border

* Tweak reserved stroke style & add constants for colors

---------

Co-authored-by: jeremystretch <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants