Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Device/Module Weight #11670

Closed
danner26 opened this issue Feb 5, 2023 · 2 comments · Fixed by #12512
Closed

Import Device/Module Weight #11670

danner26 opened this issue Feb 5, 2023 · 2 comments · Fixed by #12512
Assignees
@dhenschen
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@danner26
Copy link
Member

danner26 commented Feb 5, 2023

NetBox version

v3.4.4

Feature type

Change to existing functionality

Proposed functionality

Since we already have weight as an option, we now need to add the ability to import weight data via the CSV/YAML/JSON import. Module Types and Device Types currently do not have weight as an option to import.

NetBox devicetype-library currently has this implemented using weight value and unit. We can modify the devicetype-library if needed to support this import functionality.

Use case

Adding weight to an object is currently supported in the single import option, but not within the bulk import.

Database changes

No response

External dependencies

No response
@danner26 danner26 added the type: feature Introduction of new functionality to the application label Feb 5, 2023
@danner26 danner26 mentioned this issue Feb 5, 2023
Closed
@danner26 danner26 mentioned this issue Mar 3, 2023
Open
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 16, 2023
@dhenschen
Copy link
Contributor

I noticed that this issue is currently marked as "needs owner" and I would like to volunteer to take ownership of it. This is my first contribution to Netbox, but I am eager to learn and contribute to the project.

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 28, 2023
@jeremystretch
Copy link
Member

Thanks @dhenschen!

dhenschen added a commit to dhenschen/netbox that referenced this issue May 7, 2023
@dhenschen
11670: Add optional weight to DeviceType import
09b6b1c 
This is 1 of 2 commits to address issue netbox-community#11670

To maintain consistency, the import design of the DeviceType weight follows the
same pattern used for importing weight and weight units in DCIM Racks.
dhenschen added a commit to dhenschen/netbox that referenced this issue May 7, 2023
@dhenschen
Closes netbox-community#11670: Add weight to ModuleType import
c776482 
This is commit 2 of 2 to address and close netbox-community#11670.

To maintain consistency, the import design of the ModuleType weight follows the
same pattern used for importing weight and weight units in DCIM Racks.
@dhenschen dhenschen mentioned this issue May 7, 2023
Merged
jeremystretch added a commit that referenced this issue May 9, 2023
@dhenschen @jeremystretch
Closes #11670: Add ability to optionally import DeviceType and Module…
c55c14e 
…Type weight (#12512)

* 11670: Add optional weight to DeviceType import

This is 1 of 2 commits to address issue #11670

To maintain consistency, the import design of the DeviceType weight follows the
same pattern used for importing weight and weight units in DCIM Racks.

* Closes #11670: Add weight to ModuleType import

This is commit 2 of 2 to address and close #11670.

To maintain consistency, the import design of the ModuleType weight follows the
same pattern used for importing weight and weight units in DCIM Racks.

* Merge tests; misc cleanup

---------

Co-authored-by: jeremystretch <[email protected]>
jeremystretch added a commit that referenced this issue May 10, 2023
@jeremystretch
Changelog for #11670, #11900, #12131, #12233, #12286, #12323
2d0ac21
jsenecal pushed a commit to jsenecal/netbox that referenced this issue May 18, 2023
@dhenschen @jeremystretch @jsenecal
Closes netbox-community#11670: Add ability to optionally import Devic…
973f13c 
…eType and ModuleType weight (netbox-community#12512)

* 11670: Add optional weight to DeviceType import

This is 1 of 2 commits to address issue netbox-community#11670

To maintain consistency, the import design of the DeviceType weight follows the
same pattern used for importing weight and weight units in DCIM Racks.

* Closes netbox-community#11670: Add weight to ModuleType import

This is commit 2 of 2 to address and close netbox-community#11670.

To maintain consistency, the import design of the ModuleType weight follows the
same pattern used for importing weight and weight units in DCIM Racks.

* Merge tests; misc cleanup

---------

Co-authored-by: jeremystretch <[email protected]>
jsenecal pushed a commit to jsenecal/netbox that referenced this issue May 18, 2023
@jeremystretch @jsenecal
Changelog for netbox-community#11670, netbox-community#11900, netbox-…
d4e8092 
…community#12131, netbox-community#12233, netbox-community#12286, netbox-community#12323
@jeremystretch jeremystretch mentioned this issue May 22, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhenschen dhenschen

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #11670: Add ability to optionally import DeviceType and ModuleType weight dhenschen/netbox
4 participants
@abhi1693 @danner26 @dhenschen @jeremystretch