Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move from grpc to @grpc/grpc-js #4806

Merged
merged 2 commits into from
Jan 27, 2021
Merged

feat: move from grpc to @grpc/grpc-js #4806

merged 2 commits into from
Jan 27, 2021

Conversation

gperdomor
Copy link
Contributor

@gperdomor gperdomor commented May 15, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4799

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

a new package should be installed: @grpc/grpc-js

Other information

@tonivj5
Copy link

tonivj5 commented May 15, 2020 •
edited
Loading

Update package.json too (here and here)

@gperdomor gperdomor changed the title feat: move from grpc to @grpc/grpc-js WIP: feat: move from grpc to @grpc/grpc-js May 15, 2020
@gperdomor
Copy link
Contributor Author

@tonivj5 I have problems with tests... can you help me?

@tonivj5
Copy link

tonivj5 commented May 15, 2020

I don't know what happens and Circle CI logs aren't public, I can't check it either... Wait the reply of some maintainer, it will come! 😉

@kamilmysliwiec kamilmysliwiec added dependencies Pull requests that update a dependency file scope: microservices labels May 23, 2020
@kamilmysliwiec
Copy link
Member

image

It seems that you didn't mock the listen() method in the unit tests

@coveralls
Copy link

coveralls commented Jun 18, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 208e1d5f-fc96-4c3f-95c9-1c6986ba55dd

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.801%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-grpc.ts 7 8 87.5%
Totals Coverage Status
Change from base Build 508ee9cb-667a-4578-94ba-4cef112fd1ba: -0.02%
Covered Lines: 4923
Relevant Lines: 5193
💛 - Coveralls

@gperdomor gperdomor changed the title WIP: feat: move from grpc to @grpc/grpc-js feat: move from grpc to @grpc/grpc-js Jun 18, 2020
@gperdomor
Copy link
Contributor Author

thanks to @LastKing for solving tests issues... please @kamilmysliwiec review this when you have some time 🙏

gperdomor added 2 commits July 2, 2020 11:22
@gperdomor
feat: move from grpc to @grpc/grpc-js
a66a183 
build: update package dependencies

fix: use bindAsync in server-grpc

test(): server gprc port already listen error

test(): remove surplus commit

feat: fix packages

# Conflicts:
#	package-lock.json
#	package.json
#	sample/04-grpc/package-lock.json
#	sample/04-grpc/package.json
@gperdomor
feat: force circle ci run
1e0852f
@gperdomor
Copy link
Contributor Author

any particular reason why this PR is blocked?

@kamilmysliwiec
Copy link
Member

This PR introduces a breaking change. It won't be merged till the next major release.

@kamilmysliwiec kamilmysliwiec added this to the 8.0.0 milestone Jan 13, 2021
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jan 27, 2021
Closed
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 8.0.0 January 27, 2021 11:19
@kamilmysliwiec kamilmysliwiec merged commit 036a9fb into nestjs:8.0.0 Jan 27, 2021
@kamilmysliwiec kamilmysliwiec mentioned this pull request Feb 8, 2021
Merged
3 tasks
@jsbrain jsbrain mentioned this pull request May 28, 2021
Closed
This was referenced Jul 7, 2021
Open
Open
Merged
Merged
Open
Closed
Open
This was referenced Jul 10, 2021
Merged
Closed
Merged
Open
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced Jul 17, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Merged
This was referenced Jul 24, 2021
Closed
Open
Closed
Closed
Merged
Merged
Open
This was referenced Aug 2, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file scope: microservices status: blocked 🚫
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gperdomor @tonivj5 @kamilmysliwiec @coveralls