Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microservices] Move from grpc to @grpc/grpc-js package #4799

Closed
gperdomor opened this issue May 13, 2020 · 6 comments
Closed

[Microservices] Move from grpc to @grpc/grpc-js package #4799

gperdomor opened this issue May 13, 2020 · 6 comments
Labels
scope: microservices type: enhancement 🐺

Comments

@gperdomor
Copy link
Contributor

Feature Request

According to official grpc page, a new @grpc/grpc-js package is released, the old grpc will be deprecated... More info here
@gperdomor gperdomor added needs triage This issue has not been looked into type: enhancement 🐺 labels May 13, 2020
@gperdomor gperdomor changed the title Move from grpc to @grpc/grpc-js package [Microservices] Move from grpc to @grpc/grpc-js package May 13, 2020
@kamilmysliwiec kamilmysliwiec added scope: microservices and removed needs triage This issue has not been looked into labels May 15, 2020
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue :)?

This was referenced May 15, 2020
Merged
Merged
@ssilve1989
Copy link
Contributor

Any update on this? Looks like the PR just has small conflicts to resolve?

@gperdomor
Copy link
Contributor Author

@ssilve1989 PR updated :D

@davidhuang1550 davidhuang1550 mentioned this issue Aug 6, 2020
Closed
@adematte
Copy link

so according to the linked issue, this should be shipped on the next major version of NestJS since this introduces a breaking change. Any plans yet for when the next version will come out?

@dranzboi
Copy link

guys, when will you release a new version with grpc-js?

@kamilmysliwiec
Copy link
Member

Let's track this here #4806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: microservices type: enhancement 🐺
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gperdomor @ssilve1989 @adematte @dranzboi @kamilmysliwiec