Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neuron-wallet): use Validate decorator to verify password in… #374

Merged
merged 1 commit into from
May 26, 2019
Merged

refactor(neuron-wallet): use Validate decorator to verify password in… #374

merged 1 commit into from
May 26, 2019

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented May 25, 2019

… the key module

  1. move ResponseCode to utils/const so that CatchControllerErros doesn't depend on wallets controller.
  2. fix typo in CatchControllerError from descripor to descriptor.
  3. add Validate, Required, and Password decorators to validate parameters.
  4. use Password decorator to validate password parameters in the key module.

@Keith-CY Keith-CY requested review from ashchan and classicalliu May 25, 2019 16:32
@Keith-CY Keith-CY merged commit f572528 into nervosnetwork:develop May 26, 2019
@Keith-CY Keith-CY deleted the refactor-wallets-controller branch May 26, 2019 07:22
github-merge-queue bot pushed a commit that referenced this pull request Dec 28, 2023
* chore(deps): update dependency @types/npmlog to v7

* chore(deps): update dependency electron-builder to v24

* chore(deps): update dependency electron to v28 (#357)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Keith <[email protected]>
Co-authored-by: yanguoyu <[email protected]>

* chore(deps): update dependency eslint-config-prettier to v9

* chore(deps): update dependency lint-staged to v15

* chore(deps): update dependency lerna to v8

* chore(deps): update dependency react-i18next to v14

* fix(deps): update dependency react-router-dom to v6.21.1

* chore(deps): update dependency electron to v28.1.0 (#367)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v14 (#368)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency storybook-addon-react-router-v6 to v2

* chore(deps): update github/codeql-action action to v3 (#370)

      Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v20 (#371)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update peter-evans/commit-comment action to v3 (#372)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update tj-actions/changed-files action to v41 (#373)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: revert wait-on

* fix(deps): update dependency archiver to v6 (#375)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update typescript-eslint monorepo to v6 (#374)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: yanguoyu <[email protected]>
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
* chore(deps): update dependency @types/npmlog to v7

* chore(deps): update dependency electron-builder to v24

* chore(deps): update dependency electron to v28 (nervosnetwork#357)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Keith <[email protected]>
Co-authored-by: yanguoyu <[email protected]>

* chore(deps): update dependency eslint-config-prettier to v9

* chore(deps): update dependency lint-staged to v15

* chore(deps): update dependency lerna to v8

* chore(deps): update dependency react-i18next to v14

* fix(deps): update dependency react-router-dom to v6.21.1

* chore(deps): update dependency electron to v28.1.0 (nervosnetwork#367)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v14 (nervosnetwork#368)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency storybook-addon-react-router-v6 to v2

* chore(deps): update github/codeql-action action to v3 (nervosnetwork#370)

      Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v20 (nervosnetwork#371)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update peter-evans/commit-comment action to v3 (nervosnetwork#372)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update tj-actions/changed-files action to v41 (nervosnetwork#373)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: revert wait-on

* fix(deps): update dependency archiver to v6 (nervosnetwork#375)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update typescript-eslint monorepo to v6 (nervosnetwork#374)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: yanguoyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants