refactor(neuron-wallet): refactor helpers controller and networks con… #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troller with CatchControllerErr handle controller error in CatchControllerError
|
CI status of the fork branch is |
ashchan
reviewed
May 23, 2019
| class HelpersController { | ||
| public static generateMnemonic = (): Controller.Response<string> => { | ||
| /** |
There was a problem hiding this comment.
I'm not so sure about this but these comments don't really add many values. The scope and function names already describe themselves well enough.
There was a problem hiding this comment.
removed comments on methods of helpers controller and networks controller, but left comments on the controller classes for reminding us the controllers are used to handle messages from channels, not network requests.
bf3d7ba
…ller and networks controller
ashchan
approved these changes
May 24, 2019
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
* chore(deps): update dependency @types/npmlog to v7 * chore(deps): update dependency electron-builder to v24 * chore(deps): update dependency electron to v28 (#357) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Keith <[email protected]> Co-authored-by: yanguoyu <[email protected]> * chore(deps): update dependency eslint-config-prettier to v9 * chore(deps): update dependency lint-staged to v15 * chore(deps): update dependency lerna to v8 * chore(deps): update dependency react-i18next to v14 * fix(deps): update dependency react-router-dom to v6.21.1 * chore(deps): update dependency electron to v28.1.0 (#367) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v14 (#368) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency storybook-addon-react-router-v6 to v2 * chore(deps): update github/codeql-action action to v3 (#370) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update node.js to v20 (#371) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update peter-evans/commit-comment action to v3 (#372) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update tj-actions/changed-files action to v41 (#373) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: revert wait-on * fix(deps): update dependency archiver to v6 (#375) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update typescript-eslint monorepo to v6 (#374) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: yanguoyu <[email protected]>
Keith-CY
pushed a commit
that referenced
this pull request
Dec 28, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
yanguoyu
added a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
* chore(deps): update dependency @types/npmlog to v7 * chore(deps): update dependency electron-builder to v24 * chore(deps): update dependency electron to v28 (nervosnetwork#357) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Keith <[email protected]> Co-authored-by: yanguoyu <[email protected]> * chore(deps): update dependency eslint-config-prettier to v9 * chore(deps): update dependency lint-staged to v15 * chore(deps): update dependency lerna to v8 * chore(deps): update dependency react-i18next to v14 * fix(deps): update dependency react-router-dom to v6.21.1 * chore(deps): update dependency electron to v28.1.0 (nervosnetwork#367) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v14 (nervosnetwork#368) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency storybook-addon-react-router-v6 to v2 * chore(deps): update github/codeql-action action to v3 (nervosnetwork#370) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update node.js to v20 (nervosnetwork#371) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update peter-evans/commit-comment action to v3 (nervosnetwork#372) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update tj-actions/changed-files action to v41 (nervosnetwork#373) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: revert wait-on * fix(deps): update dependency archiver to v6 (nervosnetwork#375) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update typescript-eslint monorepo to v6 (nervosnetwork#374) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: yanguoyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…troller with CatchControllerErr