Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace Asset to Amount and better 'Asset' data format #3151

Merged
merged 1 commit into from
May 24, 2024

Conversation

yanguoyu
Copy link
Collaborator

Refer to Magickbase/neuron-public-issues#335 (comment)

For Optimize input and output storage, Neuron can not recognize whether the transaction is only sent to the current wallet. So, For transactions sent to yourself, 'Asset' needs to be shown as '--'. will not implement.

@yanguoyu yanguoyu force-pushed the fix-history-table branch from b550565 to bee1d0d Compare May 15, 2024 08:17
@Danie0918
Copy link
Collaborator

@homura @devchenyan Please have a review.

Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, but the title is somewhat confusing. Maybe a clearer title such as "correct tx history display for dao" would be more appropriate?

@yanguoyu yanguoyu changed the title fix: Replace Asset to Amount fix: Replace Asset to Amount and better 'Asset' data format May 16, 2024
@silySuper
Copy link
Collaborator

silySuper commented May 23, 2024

/package
Packaging for test is done in 9203288976. @silySuper

@yanguoyu yanguoyu force-pushed the fix-history-table branch from bee1d0d to 224d978 Compare May 24, 2024 07:13
@yanguoyu yanguoyu added this pull request to the merge queue May 24, 2024
Merged via the queue into nervosnetwork:develop with commit bed901b May 24, 2024
10 checks passed
@yanguoyu yanguoyu deleted the fix-history-table branch May 24, 2024 07:21
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants