-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace Asset
to Amount
and better 'Asset' data format
#3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith-CY
reviewed
May 15, 2024
yanguoyu
force-pushed
the
fix-history-table
branch
from
May 15, 2024 08:17
b550565
to
bee1d0d
Compare
@homura @devchenyan Please have a review. |
devchenyan
approved these changes
May 16, 2024
homura
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me, but the title is somewhat confusing. Maybe a clearer title such as "correct tx history display for dao" would be more appropriate?
homura
approved these changes
May 16, 2024
yanguoyu
changed the title
fix: Replace
fix: Replace May 16, 2024
Asset
to Amount
Asset
to Amount
and better 'Asset' data format
/package |
yanguoyu
force-pushed
the
fix-history-table
branch
from
May 24, 2024 07:13
bee1d0d
to
224d978
Compare
silySuper
approved these changes
May 24, 2024
yanguoyu
added a commit
to yanguoyu/neuron
that referenced
this pull request
May 29, 2024
…osnetwork#3151) fix: Replace `Asset` to `Amount`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to Magickbase/neuron-public-issues#335 (comment)
For Optimize input and output storage, Neuron can not recognize whether the transaction is only sent to the current wallet. So,
For transactions sent to yourself, 'Asset' needs to be shown as '--'.
will not implement.