Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Native token transfer in history add more details about CKB #335

Open
Danie0918 opened this issue Dec 13, 2023 · 10 comments
Open

Non-Native token transfer in history add more details about CKB #335

Danie0918 opened this issue Dec 13, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@Danie0918
Copy link
Contributor

Current problems:

Image

Nervos dao deposits, which show the fee, or sudt/nft transfers, which show the sudt amount/nft label, without the unique ckb and fee.

Image

NervoDAO lacks a message when depositing or withdrawing, which causes confusion for the user when the balance changes.

@Danie0918 Danie0918 added the enhancement New feature or request label Dec 13, 2023
@Danie0918 Danie0918 self-assigned this Dec 13, 2023
@Danie0918 Danie0918 added this to Neuron Dec 13, 2023
@Danie0918 Danie0918 moved this to 📋 Backlog in Neuron Dec 13, 2023
@Danie0918 Danie0918 moved this from 📋 Backlog to 🆕 New in Neuron Dec 13, 2023
@Danie0918 Danie0918 moved this from 🆕 New to 📌Planning in Neuron Dec 18, 2023
@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Jan 2, 2024
@Danie0918
Copy link
Contributor Author

【Non-Native token transfer in history add more details about CKB】

  • Requirement Description: Optimize the content of the history page to show more transaction details.

Image

  • 【History Page】Requirement Contents
  1. [Amount]: Show the number of transaction types, including positive and negative.
  2. [Balance Change]: Show the changes that occurred to the CKB balance for this transaction.
  3. 'Type' 'Balance Change' 'Time' add sorting function.
  4. When the transaction is not confirmed, the number of confirmations is displayed as ' - '.
  5. Add the transaction fee field to the drop-down list to show ' - ' when the value is empty.
  6. When withdrawals of type Nervos DAO are made, instead of showing transaction fees, compensation is shown.

Image

  • 【History Detail Page】Requirement Contents
  1. Added topology graph. (Refer to Send page)
  2. Adjust 'Block Number' 'Date' 'Income' to 'Block Height' 'Time' 'Balance Change'.
  3. Add 'Type', 'Amount',' Transaction Fee', 'Status', 'Size', and 'Cycles' fields.
  4. Add the ‘Cell Info’ field (refer to Cell Management, Synchronize the modification of 'Cell Details' to 'Cell Info')

@yanguoyu
Copy link

yanguoyu commented Jan 3, 2024

[Amount]: Show the number of transaction types, including positive and negative.

When the transaction is sent CKB to the current wallet, is the amount equal to balance change?

Add 'Type', 'Amount',' Transaction Fee', 'Status', 'Size', and 'Cycles' fields.

Just a tip: For the Cycles fields, it isn't saved into the local DB in the previous. We should add Cycles for the old transactions.

@Danie0918
Copy link
Contributor Author

[Amount]: Show the number of transaction types, including positive and negative.

When the transaction is sent CKB to the current wallet, is the amount equal to balance change?

Yes.

Add 'Type', 'Amount',' Transaction Fee', 'Status', 'Size', and 'Cycles' fields.

Just a tip: For the Cycles fields, it isn't saved into the local DB in the previous. We should add Cycles for the old transactions.

We need to add Cycles for old transactions to ensure data uniformity.

@Kirl70
Copy link

Kirl70 commented Jan 8, 2024

@yanguoyu
Copy link

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Feb 20, 2024
@homura
Copy link

homura commented Feb 20, 2024

image

IMO, the decoder here is too developer-specific for an end-user wallet. Additionally, developers may also find it confusing because the encoding of data is not restricted in any way. It is very hard to

  • find what range of characters should be selected
  • determine what encoding rule should be used.
  • choose a correct number and address decoding rule because both of them have more than one encoding rules

I suggest that we either move this feature to another product or revise it to make it more user-friendly and intuitive.

@Danie0918
Copy link
Contributor Author

image IMO, the decoder here is too developer-specific for an end-user wallet. Additionally, developers may also find it confusing because the encoding of `data` is not restricted in any way. It is very hard to
  • find what range of characters should be selected
  • determine what encoding rule should be used.
  • choose a correct number and address decoding rule because both of them have more than one encoding rules

I suggest that we either move this feature to another product or revise it to make it more user-friendly and intuitive.

The UI here references the CKB Explorer's design, and during development, it was found that it could not be better supported and was not necessary for the user, so we eliminated the feature.

@yanguoyu
Copy link

image IMO, the decoder here is too developer-specific for an end-user wallet. Additionally, developers may also find it confusing because the encoding of `data` is not restricted in any way. It is very hard to
  • find what range of characters should be selected
  • determine what encoding rule should be used.
  • choose a correct number and address decoding rule because both of them have more than one encoding rules

I suggest that we either move this feature to another product or revise it to make it more user-friendly and intuitive.

The UI here references the CKB Explorer's design, and during development, it was found that it could not be better supported and was not necessary for the user, so we eliminated the feature.

Understood, I will remove the parsing of the data.

@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Feb 26, 2024
@Danie0918 Danie0918 assigned silySuper and unassigned yanguoyu Feb 26, 2024
@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Mar 11, 2024
@Danie0918
Copy link
Contributor Author

Danie0918 commented Mar 14, 2024

[Amount]: Show the number of transaction types, including positive and negative.

When the transaction is sent CKB to the current wallet, is the amount equal to balance change?

Yes.

Add 'Type', 'Amount',' Transaction Fee', 'Status', 'Size', and 'Cycles' fields.

Just a tip: For the Cycles fields, it isn't saved into the local DB in the previous. We should add Cycles for the old transactions.

We need to add Cycles for old transactions to ensure data uniformity.

My mistake, I realized during testing that this time a misunderstanding arose. The actual requirements are as follows:

  1. Replace 'Amount' with 'Asset'.
  2. 'Asset' data format: Show the amount of assets sent/received or locked/unlocked without fees.
    • For transactions sent to yourself, 'Asset' needs to be shown as '--'.
    • NervosDAO will show + - the amount indicating the amount of CKB‘s unlock and lock, and '--' for withdrawals.

@yanguoyu @silySuper

@yanguoyu
Copy link

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron May 15, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron May 20, 2024
@Danie0918 Danie0918 assigned silySuper and unassigned yanguoyu May 24, 2024
@Danie0918 Danie0918 moved this from 👀 Testing to ✅ Done in Neuron May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

7 participants