feat: Same wallet import optimization #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devchenyan
requested review from
yanguoyu and
Keith-CY
and removed request for
yanguoyu
yanguoyu
reviewed
Dec 26, 2023
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/ReplaceDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/ReplaceDuplicateWalletDialog/index.tsx
Show resolved
Hide resolved
yanguoyu
approved these changes
Jan 2, 2024
|
/package |
|
@WhiteMinds @homura Please have a review. |
homura
reviewed
Jan 16, 2024
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
homura
reviewed
Jan 18, 2024
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/DetectDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/ReplaceDuplicateWalletDialog/index.tsx
Outdated
Show resolved
Hide resolved
homura
approved these changes
Jan 18, 2024
|
Conflicted |
|
/package |
silySuper
approved these changes
Jan 29, 2024
yanguoyu
pushed a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
* fix: issue 291 * fix * fix * fix: remove unused files * fix: test * fix: Same wallet import optimization * fix * fix: comments * fix: comments * fix: comments * fix: comments * fix: Merge * fix --------- Co-authored-by: Chen Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: Magickbase/neuron-public-issues#291
Screen-2023-12-24-121051.mp4
Screen-2023-12-24-121443.mp4