Same wallet import optimization

[Danie0918]

Currently, we generate multiple wallets when importing the same wallet multiple times.

This can be used to reset a password using a mnemonic, are there any other scenarios other than this?

If not, I will consider adding a reset password feature and grouping imports of the same wallet into the same category to make account management less difficult.

[Keith-CY]

Currently, we generate multiple wallets when importing the same wallet multiple times.

This can be used to reset a password using a mnemonic, are there any other scenarios other than this?

If not, I will consider adding a reset password feature and grouping imports of the same wallet into the same category to make account management less difficult.

Resetting the password can be done by the following steps if the mnemonics file is accessible:

1. backup keystore of the old password
2. remove wallet of the old password
3. import wallet via mnemonics, using a new password
4. remove the backup once the new wallet has been verified.

So the reset password can be excluded from the reasons of importing the same wallet multiple times.

From the description in the top message, I found this issue is to group wallets instead of preventing from importing the same wallet multiple times. IMO, grouping them is a good idea but adding a reset password button is unnecessary because it's a low-frequency function and can be done by the solution above.

[yanguoyu]

I guess @Danie0918 means if import a wallet multisig times, there will only exist one wallet. @Keith-CY

There exists one issue, import a watched-only wallet with the public key and then import this wallet with a keystone file and password. They are the same wallet but the permission is different. I don't know whether we should merge these two wallets. @Danie0918

[Danie0918]

I guess @Danie0918 means if import a wallet multisig times, there will only exist one wallet. @Keith-CY

Yes, I'm mostly trying to solve the problem of multiple identical wallets existing.Resetting passwords may be a reason why users import the same wallet multiple times, so it can be optimized to be easier to work with.

There exists one issue, import a watched-only wallet with the public key and then import this wallet with a keystone file and password. They are the same wallet but the permission is different. I don't know whether we should merge these two wallets. @Danie0918

In this case, we should keep the wallet with higher permissions.

[Keith-CY]

If this issue is to solve the problem that wallet is imported repeatedly, I will suggest preventing them from being imported instead of combining existing wallets. Because modification of users' data is sensitive.

[Danie0918]

PRD

【Same wallet import optimization】

• Requirement Description:Currently users can import the same wallet multiple times, which increases the complexity of management and needs to be optimized.

• Requirement Contents

1. Importing duplicate wallets is no longer supported. When importing a duplicate wallet, the user is prompted to select an existing wallet to replace or cancel the import.
2. For users with the same wallet, a pop-up window prompts the user after updating the software and no longer pops up after the user closes or operates it.

• The pop-up window displays the same wallets grouped in the order of the existing wallets and provides a radio option for the user to select the wallets to be retained in each group.
• After selecting the wallets to keep, the user clicks Confirm to delete the unselected wallets in the same group.
• When no wallet is selected for the same grouping, no operations are performed on that group's wallets.
• The user may choose to operate and confirm only a portion of the grouped reserved wallets, but may not click to confirm without selecting any wallets.

3. Settings - Wallets Add option to detected duplicate wallets:

• This option is only available if the same wallet exists.
• Click to bring up the Detect Duplicate Wallet pop-up and proceed.

[yanguoyu]

1. This option is only available if the same wallet exists.

How about hiding this button when there is no duplicate wallet? Maybe most of the users does not import duplicate wallet, it will have less effect.

2. When no wallet is selected for the same grouping, no operations are performed on that group's wallets.

Does it mean the users can cancel the radio option?

[Danie0918]

How about hiding this button when there is no duplicate wallet? Maybe most of the users does not import duplicate wallet, it will have less effect.

Yes, it was considered like this.

Does it mean the users can cancel the radio option?

Here is a relatively flexible option for the user, who can choose to operate on some of the duplicate wallets while keeping some of the duplicate wallets.

[Danie0918]

UI：https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=28437-26385&mode=design&t=AY5lLSGCmoHUwzpQ-0

[devchenyan]

fixed: nervosnetwork/neuron#3001

[silySuper]

verified