Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize the setting of sync start block in light client mode. #2994

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: Optimize the setting of sync start block in light client mode. #2994

merged 1 commit into from
Jan 17, 2024

Conversation

yanguoyu
Copy link
Collaborator

Refer to Magickbase/neuron-public-issues#304.

  1. Show the last setted start block number
image
  1. If the current set start block number is less than before
image
  1. If the current set start block number is bigger than the header tip block number
image

@yanguoyu yanguoyu mentioned this pull request Dec 20, 2023
Open
@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from cb6cf7f to 2d736d6 Compare December 20, 2023 08:45
@Keith-CY
Copy link
Collaborator

Keith-CY commented Dec 28, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7345589503. @Keith-CY

@Keith-CY
Copy link
Collaborator

Please have a review @homura @WhiteMinds @devchenyan @zhangyouxin

@Keith-CY Keith-CY requested a review from zhangyouxin December 28, 2023 08:11
@Keith-CY
Copy link
Collaborator

Please have a review @homura @WhiteMinds @devchenyan @zhangyouxin

@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from 5aeb981 to 2acaf02 Compare December 29, 2023 04:34
@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from 2acaf02 to a9cfc82 Compare December 29, 2023 10:41
@Keith-CY Keith-CY mentioned this pull request Dec 31, 2023
Closed
@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from a9cfc82 to 877d539 Compare January 2, 2024 01:51
@yanguoyu yanguoyu requested a review from Keith-CY January 9, 2024 10:44
@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from 3dbbf4e to f7bef5b Compare January 10, 2024 02:27
Keith-CY
Keith-CY reviewed Jan 11, 2024
View reviewed changes
packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated Show resolved Hide resolved
packages/neuron-ui/src/locales/en.json Outdated Show resolved Hide resolved
packages/neuron-ui/src/locales/en.json Outdated Show resolved Hide resolved
packages/neuron-ui/src/locales/en.json Show resolved Hide resolved
packages/neuron-wallet/src/controllers/api.ts Outdated Show resolved Hide resolved
@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch 2 times, most recently from 6a2b12f to 3f40ccc Compare January 12, 2024 08:54
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Jan 16, 2024 •
edited by github-actions bot
Loading

/package
Packageing failed in 7535904224. @yanguoyu

@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from 3f40ccc to 6ebc225 Compare January 16, 2024 06:37
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Jan 16, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7537937385. @yanguoyu

@yanguoyu yanguoyu force-pushed the feat-opt-start-block branch from 6ebc225 to 2b05e94 Compare January 17, 2024 00:35
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Jan 17, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7549357935. @yanguoyu

@yanguoyu yanguoyu enabled auto-merge January 17, 2024 07:50
@yanguoyu yanguoyu added this pull request to the merge queue Jan 17, 2024
Merged via the queue into nervosnetwork:develop with commit ae34b2b Jan 17, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-opt-start-block branch January 17, 2024 08:47
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@yanguoyu
feat: Optimize the setting of sync start block in light client mode. (n…
c521664 
…ervosnetwork#2994)
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silySuper silySuper silySuper approved these changes

@devchenyan devchenyan devchenyan approved these changes

@homura homura homura approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

@FrederLu FrederLu Awaiting requested review from FrederLu

@zhangyouxin zhangyouxin Awaiting requested review from zhangyouxin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanguoyu @Keith-CY @homura @devchenyan @silySuper