-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the setting of sync start block in light client mode #304
Comments
【Optimize the setting of sync start block in light client mode】
|
Is it a wrong description? Does it should be
It notifies that |
I'll change it. It's still set synchronization start block.
Of course, it would be better to just disable it, I had previously thought that we couldn't get the latest blocks in real time. It doesn't need to be very real-time here, refreshing is unnecessary. |
I suggest clearing all synchronized data and starting from the setting start block number if the set start block number is smaller than the last setting(or synced block number). When users set a smaller setting, it will not sync from the smaller setting because the light client has synced to a higher block number. |
Notifying the user would be better, I'll add a popup alert later. |
Another note could be added that if there are no transactions on the chain, or users assure there are no transactions on the chain, the tip block number could be set. This note comes from the case that users find empty transaction lists on the explorer and they don't know how to continue. |
Is this prompted when setting the start block?But for new wallets, we are not prompted to set the start block. |
Yes, it should be noted when setting the start point, but it's not the case of a freshly generated wallet(and a new wallet doesn't need the step of specifying the start point because it will be done automatically). It's the case that a wallet was created before but never used. So the user cannot find the earliest transaction on ckb explorer when the wallet is imported. |
In order to be compatible with the case of setting the starting block for wallets with no transaction history, we have divided the case of setting the starting block into 2 cases:
|
I'm afraid these two messages should be displayed at the same time because Neuron cannot get the transaction count before the synchronization. |
verified |
In the current light client mode, the user can set the synchronization start block. When the block number set by the user is after the historical transaction block number, then the historical transaction will not be synchronized, but displaying 100% synchronization can be misleading to the user.
This needs to be optimized:
1.Add a strong hint when setting the start block number.
2.Consider optimizing the setting of the start block number range not to exceed the latest block number.
3.Add a reminder that the start block number has been set.
The text was updated successfully, but these errors were encountered: