Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid unexpected dialog shown. #2928

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

yanguoyu
Copy link
Collaborator

To avoid unexpected dialog that notifies the user of an external node shown.

  1. Set the process to null when the started pid equals the current process pid.
  2. Stop the get tip number when switching the network and start after starting the node.
  3. Add debounce time to start node, that is avoid the user switching the internal network faster.

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Nov 10, 2023

/package
Packaging for test is done in 6822238187. @yanguoyu

@Keith-CY
Copy link
Collaborator

In what situations will the dialog be displayed mistakenly?

@yanguoyu yanguoyu force-pushed the fix-unexpected-dialog branch from 2a5a17d to 2e863d1 Compare November 17, 2023 04:17
@yanguoyu
Copy link
Collaborator Author

In what situations will the dialog be displayed mistakenly?

When the connectionStatusSubject broadcasts true for the last selected node. So I restart the subscribe which gets the tip number when the network switches.

@Keith-CY
Copy link
Collaborator

In what situations will the dialog be displayed mistakenly?

When the connectionStatusSubject broadcasts true for the last selected node. So I restart the subscribe which gets the tip number when the network switches.

Got it

@yanguoyu yanguoyu requested a review from Keith-CY November 17, 2023 06:00
@silySuper
Copy link
Collaborator

silySuper commented Nov 21, 2023

/package
Packaging for test is done in 6938651819. @silySuper

@yanguoyu yanguoyu force-pushed the fix-unexpected-dialog branch from ef79364 to 26fa8f2 Compare November 21, 2023 08:30
@yanguoyu yanguoyu requested a review from homura November 21, 2023 08:44
@yanguoyu yanguoyu added this pull request to the merge queue Nov 22, 2023
Merged via the queue into nervosnetwork:develop with commit dffd921 Nov 22, 2023
10 checks passed
@yanguoyu yanguoyu deleted the fix-unexpected-dialog branch November 22, 2023 01:07
@Keith-CY Keith-CY mentioned this pull request Nov 23, 2023
@Keith-CY Keith-CY mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants