Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with adapt switch internal network type, and notify the user network type is not running external #313

Closed
silySuper opened this issue Nov 6, 2023 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@silySuper
Copy link

1.The pop up add network window can only add network name ,the URL can not be added and is 127.0.0.1:8114 by default.
截屏2023-11-06 15 52 18

2.Must chose external node , or else the pop up window can not be closed. At this time ,my ckb node config is null.

2023-11-06.16.02.19.mov

3.The change feature like a tip.May be click the change icon to change is better in user experience.

2023-11-06.16.09.59.mov

4.Switch internal and external nodes back and forth,the internal node port can not be changed to 8116.

2023-11-06.16.21.53.mov
@silySuper silySuper added the bug Something isn't working label Nov 6, 2023
@silySuper silySuper added this to Neuron Nov 6, 2023
@yanguoyu
Copy link

yanguoyu commented Nov 6, 2023

1.The pop up add network window can only add network name ,the URL can not be added and is 127.0.0.1:8114 by default.

Because the used port is 8114, setting the remote as 8114 is better. Otherwise, after the user adds a network, there will be no network to choose either. @Danie0918 what do you think?

For 2 and 4, which action package do you use?

@silySuper
Copy link
Author

1.The pop up add network window can only add network name ,the URL can not be added and is 127.0.0.1:8114 by default.

Because the used port is 8114, setting the remote as 8114 is better. Otherwise, after the user adds a network, there will be no network to choose either. @Danie0918 what do you think?

For 2 and 4, which action package do you use?

Because I download and test before the latest package:this package is my testing package: https://github.com/nervosnetwork/neuron/actions/runs/6766660238

@yanguoyu
Copy link

yanguoyu commented Nov 6, 2023

1.The pop up add network window can only add network name ,the URL can not be added and is 127.0.0.1:8114 by default.

Because the used port is 8114, setting the remote as 8114 is better. Otherwise, after the user adds a network, there will be no network to choose either. @Danie0918 what do you think?
For 2 and 4, which action package do you use?

Because I download and test before the latest package:this package is my testing package: https://github.com/nervosnetwork/neuron/actions/runs/6766660238

Could you test with https://github.com/nervosnetwork/neuron/actions/runs/6767347131?

@Danie0918 Danie0918 moved this to 👀 Testing in Neuron Nov 6, 2023
@Danie0918
Copy link
Contributor

Because the used port is 8114, setting the remote as 8114 is better. Otherwise, after the user adds a network, there will be no network to choose either. @Danie0918 what do you think?

It's fine.

@silySuper
Copy link
Author

silySuper commented Nov 7, 2023

https://github.com/nervosnetwork/neuron/actions/runs/6781538780
1.This package does not see switching function in internal node
2.Internal node port does not change to 8116

2023-11-07.16.41.26.mov

@silySuper
Copy link
Author

5.When change to light mode ,"Switch to XXX" font is also black which is not obvious.

截屏2023-11-07 16 45 45

@silySuper
Copy link
Author

6.When change to light client,the pop up window shows no external network. And the port also changed from 9000 to 9001.
截屏2023-11-07 16 57 49

@Keith-CY
Copy link
Member

Keith-CY commented Nov 7, 2023

nervosnetwork/neuron/actions/runs/6781538780 1.This package does not see switching function in internal node 2.Internal node port does not change to 8116

2023-11-07.16.41.26.mov

Switch between mainnet full node and testnet full node has been disabled by yanguoyu/neuron#98

Reason:

Testnet full node can be accessed by an external node, and it requires another assume valid target for fast sync.

Besides, it's prone to download massive data by accident.

So Testnet full node is removed from the built-in network options. And users may connect to an external one.

@yanguoyu
Copy link

yanguoyu commented Nov 7, 2023

https://github.com/nervosnetwork/neuron/actions/runs/6781538780 1.This package does not see switching function in internal node 2.Internal node port does not change to 8116

2023-11-07.16.41.26.mov

5.When change to light mode ,"Switch to XXX" font is also black which is not obvious.

nervosnetwork/neuron@e97f8d6 has fixed 2 and 5.

@silySuper
Copy link
Author

silySuper commented Nov 8, 2023

https://github.com/nervosnetwork/neuron/actions/runs/6781538780 1.This package does not see switching function in internal node 2.Internal node port does not change to 8116

2023-11-07.16.41.26.mov

Now pop up window shows in light client network ,when click ignore external node,it shows the window again.It is easier to show when built-in light node service change to internal node back and forth ,but ckb-light-client background process can not be closed.Not appear certainly.

截屏2023-11-08 10 52 12
2023-11-08.11.00.37.mov

neuron_debug_1699412501883.zip

@silySuper
Copy link
Author

No.1 does not need changed.
No.2 and No.4 does not need changed in external node.But shows up in light client network(No.6).
No.3 wait for verification.
No.5 has verified.

@yanguoyu
Copy link

yanguoyu commented Nov 8, 2023

No.3 has fixed by nervosnetwork/neuron#2926.

@silySuper
Copy link
Author

No.3 has verified.

@yanguoyu
Copy link

Please check the No.6 by nervosnetwork/neuron#2928

@yanguoyu
Copy link

No.3 has been updated with the new UI nervosnetwork/neuron#2926.

@silySuper
Copy link
Author

No.6 has verified.

@silySuper
Copy link
Author

No.3 has verified.

@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Nov 13, 2023
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants