Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Click current network button to switch type. #2926

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Nov 8, 2023

  1. Click here to switch the network type, the tooltip is just a information
image

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Nov 8, 2023

/package
Packaging for test is done in 6793378225. @yanguoyu

@yanguoyu yanguoyu enabled auto-merge November 8, 2023 07:38
@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 8, 2023

The interaction is changed here, and I'd like to know how it is supposed to be before.
It's probably about the feedback that switch to mainnet is hard to click, but it can be easily fixed by dismissing the tooltip a bit later.

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Nov 9, 2023

The interaction is changed here, and I'd like to know how it is supposed to be before. It's probably about the feedback that switch to mainnet is hard to click, but it can be easily fixed by dismissing the tooltip a bit later.

Before switching network type by clicking the tooltip, now the tooltip only shows switch information, and click the current network type to switch it.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 9, 2023

The interaction is changed here, and I'd like to know how it is supposed to be before. It's probably about the feedback that switch to mainnet is hard to click, but it can be easily fixed by dismissing the tooltip a bit later.

Before switching network type by clicking the tooltip, now the tooltip only shows switch information, and click the current network type to switch it.

I got the change of interaction, but I wonder why. I ask this because

  1. change of newly released UX implies that it's not fully polished
  2. switch to testnet is not for general users, so it's better to be available in an implicit way. Placing it next to switch to light client is prone to click.
    • When light client is not selected, clicking on light mainnet will activate light client mainnet
    • When light client is selected, clicking on light mainnet will switch to light client testnet

I prefer a clear UX, with a clear prompt in the hot zone.
cc @Danie0918

@Danie0918
Copy link
Collaborator

The interaction is changed here, and I'd like to know how it is supposed to be before. It's probably about the feedback that switch to mainnet is hard to click, but it can be easily fixed by dismissing the tooltip a bit later.

Before switching network type by clicking the tooltip, now the tooltip only shows switch information, and click the current network type to switch it.

I got the change of interaction, but I wonder why. I ask this because

  1. change of newly released UX implies that it's not fully polished

  2. switch to testnet is not for general users, so it's better to be available in an implicit way. Placing it next to switch to light client is prone to click.

    • When light client is not selected, clicking on light mainnet will activate light client mainnet
    • When light client is selected, clicking on light mainnet will switch to light client testnet

I prefer a clear UX, with a clear prompt in the hot zone. cc @Danie0918

The main purpose here is to make it easy to switch between the built-in networks in order to research and experience the CKB network with the user. However, for users the network changes need to be more clearly prompted, this I communicate with Kirl.

@Danie0918
Copy link
Collaborator

The interaction is changed here, and I'd like to know how it is supposed to be before. It's probably about the feedback that switch to mainnet is hard to click, but it can be easily fixed by dismissing the tooltip a bit later.

Before switching network type by clicking the tooltip, now the tooltip only shows switch information, and click the current network type to switch it.

I got the change of interaction, but I wonder why. I ask this because

  1. change of newly released UX implies that it's not fully polished

  2. switch to testnet is not for general users, so it's better to be available in an implicit way. Placing it next to switch to light client is prone to click.

    • When light client is not selected, clicking on light mainnet will activate light client mainnet
    • When light client is selected, clicking on light mainnet will switch to light client testnet

I prefer a clear UX, with a clear prompt in the hot zone. cc @Danie0918

The main purpose here is to make it easy to switch between the built-in networks in order to research and experience the CKB network with the user. However, for users the network changes need to be more clearly prompted, this I communicate with Kirl.

UI update:https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=28088%3A7597&mode=design&t=YIECbCV90dwff9JS-1

@yanguoyu @silySuper

@yanguoyu yanguoyu force-pushed the fix-switch-networktype branch from a000497 to 244d05f Compare November 10, 2023 08:20
@yanguoyu
Copy link
Collaborator Author

The interaction is changed here, and I'd like to know how it is supposed to be before. It's probably about the feedback that switch to mainnet is hard to click, but it can be easily fixed by dismissing the tooltip a bit later.

Before switching network type by clicking the tooltip, now the tooltip only shows switch information, and click the current network type to switch it.

I got the change of interaction, but I wonder why. I ask this because

  1. change of newly released UX implies that it's not fully polished

  2. switch to testnet is not for general users, so it's better to be available in an implicit way. Placing it next to switch to light client is prone to click.

    • When light client is not selected, clicking on light mainnet will activate light client mainnet
    • When light client is selected, clicking on light mainnet will switch to light client testnet

I prefer a clear UX, with a clear prompt in the hot zone. cc @Danie0918

The main purpose here is to make it easy to switch between the built-in networks in order to research and experience the CKB network with the user. However, for users the network changes need to be more clearly prompted, this I communicate with Kirl.

UI update:https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=28088%3A7597&mode=design&t=YIECbCV90dwff9JS-1

@yanguoyu @silySuper

@silySuper update

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Nov 10, 2023

/package
Packageing failed in 6822410890. @yanguoyu

@silySuper
Copy link
Collaborator

silySuper commented Nov 10, 2023

/package
Packaging for test is done in 6822918614. @silySuper

@yanguoyu yanguoyu added this pull request to the merge queue Nov 14, 2023
Merged via the queue into nervosnetwork:develop with commit b41c91e Nov 14, 2023
10 checks passed
@yanguoyu yanguoyu deleted the fix-switch-networktype branch November 14, 2023 06:06
@Keith-CY Keith-CY mentioned this pull request Nov 23, 2023
@Keith-CY Keith-CY mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants