chore: upgrade p2p/tokio #2050
Merged
chore: upgrade p2p/tokio #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
benchmark |
Benchmark Result
|
doitian
requested review from
zhangsoledad and
yangby-cryptape
and removed request for
xxuejie
TheWaWaR
approved these changes
Apr 30, 2020
quake
approved these changes
May 1, 2020
|
bors r=TheWaWaR,quake |
bors bot
added a commit
that referenced
this pull request
May 1, 2020
2050: chore: upgrade p2p/tokio r=TheWaWaR,quake a=driftluo
1. Upgrade p2p, use new `BlockingFlag` to optimize performance
2. Upgrade tokio, allow recursive call `block_in_place`
p2p release note:
```
Bug Fix
Fix session proto open/close by user part(#220)
Features
Replace unsplit with assignment(#225)
Upgrade tokio util(#224)
Avoids unnecessary session id checking(#223)
Check all underscore(#228)
Use flag to control how to use block_in_place(#226)
More test(#227/#220)
```
tokio release note:
```
Fix
rt: support block_in_place in more contexts
stream: no panic in merge() and chain() when using size_hint()
task: include visibility modifier when defining a task-local
sync: broadcast closing the channel no longer requires capacity
Added
rt: runtime::Handle::block_on
```
2053: test: save integration test logs in a specified directory r=keroro520,doitian a=yangby-cryptape
Currently, it's too hard to distinguish between integration test logs and other temporary logs, especially when make integration test to be automated.
Co-authored-by: driftluo <[email protected]>
Co-authored-by: Boyu Yang <[email protected]>
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockingFlagto optimize performanceblock_in_placep2p release note:
tokio release note: