Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] the cli type_hash returns "No config file found!" #227

Closed
kellyshang opened this issue Jan 25, 2019 · 7 comments
Closed

[docs] the cli type_hash returns "No config file found!" #227

kellyshang opened this issue Jan 25, 2019 · 7 comments

Comments

@kellyshang
Copy link

in CKB's repo directory, use the command "./target/release/ckb cli type_hash" now returns "No config file found!".
@ashchan
Copy link
Contributor

ashchan commented Jan 25, 2019

@kellyshang Did you try running start from removing nodes and copying the nodes_template? When I do that I get:

~/Projects/ckb/ckb (develop)$ ./target/debug/ckb cli type_hash
0x0da2fe99fe549e082d4ed483c2e968a89ea8d11aabf5d79e5cbf06522de6e674
2019-01-25 15:43:18.726 +09:00 main INFO main  Setup with config /Users/james/Projects/ckb/ckb/nodes/default.json

BTW, this looks like a CKB core issue, not the SDK problem if it does happen.

@doitian
Copy link
Member

doitian commented Jan 25, 2019

In some version, ckb cli did require the config file, but the latest version should not. @zhangsoledad please confirm it.

@ashchan
Copy link
Contributor

ashchan commented Jan 25, 2019

Update: as could see in my local output above, I was playing with the develop branch HEAD.

@zhangsoledad
Copy link
Member

zhangsoledad commented Jan 25, 2019 •
edited
Loading

In some version, ckb cli did require the config file, but the latest version should not. @zhangsoledad please confirm it.

cli type_hash require config, cli keygendoes not.

@ashchan
Copy link
Contributor

ashchan commented Jan 25, 2019

@zhangsoledad Could you explain a bit more: which config (file name?) does ckb cli require? Does node_templates contain that config file by default?

@doitian doitian transferred this issue from nervosnetwork/ckb-demo-ruby Jan 25, 2019
@doitian
Copy link
Member

doitian commented Jan 25, 2019

When a subcommand needs a config file, it tries ckb.json, nodes/default.json in working directory when no one is specified in command line.

@kellyshang
Copy link
Author

I tried in v0.6.0 start from removing old nodes folder and copying the node_template, it can return the type_hash now.
Thanks for all your reply.

@doitian doitian closed this as completed Feb 14, 2019
bors bot added a commit that referenced this issue May 1, 2020
@bors @driftluo @yangby-cryptape
Merge #2050 #2053
f27ed20 
2050: chore: upgrade p2p/tokio r=TheWaWaR,quake a=driftluo

1. Upgrade p2p, use new `BlockingFlag` to optimize performance
2. Upgrade tokio, allow recursive call `block_in_place`

p2p release note:
```
Bug Fix

    Fix session proto open/close by user part(#220)

Features

    Replace unsplit with assignment(#225)
    Upgrade tokio util(#224)
    Avoids unnecessary session id checking(#223)
    Check all underscore(#228)
    Use flag to control how to use block_in_place(#226)
    More test(#227/#220)
```

tokio release note:
```
Fix
    rt: support block_in_place in more contexts
    stream: no panic in merge() and chain() when using size_hint()
    task: include visibility modifier when defining a task-local
    sync: broadcast closing the channel no longer requires capacity 

Added
    rt: runtime::Handle::block_on
```

2053: test: save integration test logs in a specified directory r=keroro520,doitian a=yangby-cryptape

Currently, it's too hard to distinguish between integration test logs and other temporary logs, especially when make integration test to be automated.

Co-authored-by: driftluo <[email protected]>
Co-authored-by: Boyu Yang <[email protected]>
bors bot added a commit that referenced this issue May 1, 2020
@bors @driftluo
Merge #2050
e492116 
2050: chore: upgrade p2p/tokio r=TheWaWaR,quake a=driftluo

1. Upgrade p2p, use new `BlockingFlag` to optimize performance
2. Upgrade tokio, allow recursive call `block_in_place`

p2p release note:
```
Bug Fix

    Fix session proto open/close by user part(#220)

Features

    Replace unsplit with assignment(#225)
    Upgrade tokio util(#224)
    Avoids unnecessary session id checking(#223)
    Check all underscore(#228)
    Use flag to control how to use block_in_place(#226)
    More test(#227/#220)
```

tokio release note:
```
Fix
    rt: support block_in_place in more contexts
    stream: no panic in merge() and chain() when using size_hint()
    task: include visibility modifier when defining a task-local
    sync: broadcast closing the channel no longer requires capacity 

Added
    rt: runtime::Handle::block_on
```

Co-authored-by: driftluo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ashchan @doitian @zhangsoledad @kellyshang