Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 759 #2122

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Issue 759 #2122

merged 2 commits into from
Aug 7, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz August 6, 2024 08:08
@zmcNotafraid zmcNotafraid force-pushed the issue-759 branch 2 times, most recently from ba832e5 to 842d22f Compare August 6, 2024 08:49
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (f373f6b) to head (e30a3cd).
Report is 356 commits behind head on develop.

Files Patch % Lines
app/workers/token_collection_tag_worker.rb 85.71% 1 Missing ⚠️
app/workers/xudt_tag_worker.rb 80.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (e30a3cd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (e30a3cd)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2122      +/-   ##
===========================================
- Coverage    67.56%   62.55%   -5.01%     
===========================================
  Files          289      349      +60     
  Lines         7944     9803    +1859     
===========================================
+ Hits          5367     6132     +765     
- Misses        2577     3671    +1094     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Aug 7, 2024
Merged via the queue into nervosnetwork:develop with commit 67c6515 Aug 7, 2024
2 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the issue-759 branch August 7, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants